1235188 - Fix -Wformat warnings in security/certverifier/

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: security-certverifier_Wformat.patch

security/certverifier/NSSCertDBTrustDomain.cpp:433:26 [-Wformat] format specifies type 'long' but the argument has underlying type 'int'
security/certverifier/NSSCertDBTrustDomain.cpp:433:48 [-Wformat] format specifies type 'long long' but the argument has type 'mozilla::pkix::Time'

pkix::Time is an object. I added a new elapsedSecondsDebug() member function to peek at Time's elapsedSecondsAD member variable. Since this is break the Time abstraction, I hid the new member function behind #ifdef DEBUG so no one is tempted to use it in release code. Alternatively, the MOZ_LOG() call could be changed to not log cachedResponseValidThrough.

Comment 1

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 8702034 [details] [diff] [review]
security-certverifier_Wformat.patch

Review of attachment 8702034 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, let's just go with the alternative and remove logging cachedResponseValidThrough (we don't log other pkix::Times as far as I recall, and the format isn't readily comparable to other ways of obtaining the time, so I don't think it's that useful).

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: certverifier-Wformat-v2.patch

Patch v2: Fix two -Wformat warnings in certverifier by downgrading %ld format specifier to %d and removing cachedResponseValidThrough.

security/certverifier/NSSCertDBTrustDomain.cpp:433:26 [-Wformat] format specifies type 'long' but the argument has underlying type 'int'

security/certverifier/NSSCertDBTrustDomain.cpp:433:48 [-Wformat] format specifies type 'long long' but the argument has type 'mozilla::pkix::Time'

Comment 3

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 8705963 [details] [diff] [review]
certverifier-Wformat-v2.patch

Review of attachment 8705963 [details] [diff] [review]:
-----------------------------------------------------------------

Great - thanks.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7628ca83e10

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d7628ca83e10