Open Bug 1235198 Opened 8 years ago

Possibly wrong documentation for "once" vs. "onepass" in jobqueue.pl

Categories

(Bugzilla :: Administration, task)

5.0.2
task
Not set
minor

Tracking

()

People

(Reporter: tschoening, Unassigned)

Details

> once
> Checks the job queue once, executes the first item found (if
> any, up to a limit of 1000 items) and then exits

vs.

> onepass
> Checks the job queue, executes all items found, and then exits

From my understanding of the implementations Bugzilla::JobQueue::work_once and ::work_until_done, the hint for the limit of 1000 items needs to be added to "onepass" instead of "once", because "onepass" is iterating multiple items until that limit is reached and work_once is really only processing exactly one item, regardless if more are available.

Shouldn't the correct wording be the following or am I misunderstanding the docs?

> once
> Checks the job queue once, executes the first item found (if
> any) and then exits

vs.

> onepass
> Checks the job queue once, executes all items found up to a limit of 1000 items, and then exits
You need to log in before you can comment on or make changes to this bug.