1235235 - Fix -Wimplicit-fallthrough warning in media/mtransport/

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: mtransport_MOZ_FALLTHROUGH.patch

media/mtransport/transportlayerdtls.cpp:872:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels

This patch fixes a clang -Wimplicit-fallthrough warning (not yet enabled by default in mozilla-central) about switch cases that fall through without a break or return statement. Warnings about intentional fallthroughs can be suppressed with MOZ_FALLTHROUGH, a MFBT macro for a clang compiler annotation. MOZ_FALLTHROUGH is only needed on cases that have code:

switch (foo) {
  case 1: // These cases have no code. No fallthrough annotations are needed.
  case 2:
  case 3:
    foo = 4; // This case has code, so a fallthrough annotation is needed:
    MOZ_FALLTHROUGH;
  default:
    return foo;
}

Comment 1

[Eric Rescorla (:ekr)]

Comment on attachment 8702097 [details] [diff] [review]
mtransport_MOZ_FALLTHROUGH.patch

Review of attachment 8702097 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/526f309b5ba4

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/526f309b5ba4