1235238 - Fix -Wimplicit-fallthrough warning in ssltunnel

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: ssltunnel_Wimplicit-fallthrough.patch

testing/mochitest/ssltunnel/ssltunnel.cpp:1387:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels

This patch fixes a clang -Wimplicit-fallthrough warning (not yet enabled by default in mozilla-central) about switch cases that fall through without a break, return, or continue statement.

Warnings about intentional fallthroughs can be suppressed with MOZ_FALLTHROUGH, a MFBT macro for a clang compiler annotation. MOZ_FALLTHROUGH is only needed on cases that have code:

switch (foo) {
  case 1: // These cases have no code. No fallthrough annotations are needed.
  case 2:
  case 3:
    foo = 4; // This case has code, so a fallthrough annotation is needed:
    MOZ_FALLTHROUGH;
  default:
    return foo;
}

Comment 1

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4c70584b22c7

Comment 2

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4c70584b22c7