Closed Bug 1235298 Opened 9 years ago Closed 9 years ago

Fix -Wimplicit-fallthrough warnings in netwerk/

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla46
Tracking Flags:
Tracking Status
firefox46 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

netwerk_MOZ_FALLTHROUGH.patch
23.73 KB, patch
mcmanus
: review+
Details | Diff | Splinter Review
MOZ_FALLTHROUGH (bug 1215411) is an annotation to suppress -Wimplicit-fallthrough warnings about switch cases that intentionally fall through without a break or return statement. netwerk/base/nsURLHelper.cpp:440:11 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache/nsDiskCacheDevice.cpp:308:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache/nsDiskCacheDevice.cpp:309:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache/nsDiskCacheDevice.cpp:311:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache/nsDiskCacheDevice.cpp:312:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache/nsDiskCacheDevice.cpp:313:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache/nsDiskCacheDevice.cpp:314:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache/nsDiskCacheDevice.cpp:315:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache/nsDiskCacheDevice.cpp:316:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache/nsDiskCacheDevice.cpp:317:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache/nsDiskCacheDevice.cpp:318:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache2/CacheHashUtils.cpp:60:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache2/CacheHashUtils.cpp:61:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache2/CacheHashUtils.cpp:63:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache2/CacheHashUtils.cpp:64:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache2/CacheHashUtils.cpp:65:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache2/CacheHashUtils.cpp:66:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache2/CacheHashUtils.cpp:67:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache2/CacheHashUtils.cpp:68:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache2/CacheHashUtils.cpp:69:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache2/CacheHashUtils.cpp:70:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache2/CacheHashUtils.cpp:160:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache2/CacheHashUtils.cpp:161:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache2/CacheIndex.cpp:132:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache2/CacheIndex.cpp:456:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache2/CacheIndex.cpp:1139:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cache2/CacheStorageService.cpp:426:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cookie/nsCookieService.cpp:900:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cookie/nsCookieService.cpp:958:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cookie/nsCookieService.cpp:1054:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cookie/nsCookieService.cpp:1104:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/cookie/nsCookieService.cpp:1127:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/protocol/http/Http2Stream.cpp:1357:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/protocol/http/SpdyStream31.cpp:1559:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/protocol/http/nsHttpTransaction.cpp:1590:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/protocol/websocket/WebSocketChannel.cpp:2059:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/sctp/datachannel/DataChannel.h:531:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/streamconv/converters/mozTXTToHTMLConv.cpp:55:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/streamconv/converters/mozTXTToHTMLConv.cpp:102:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/streamconv/converters/mozTXTToHTMLConv.cpp:514:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels netwerk/streamconv/converters/nsHTTPCompressConv.cpp:256:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
Attachment #8702191 - Flags: review?(mcmanus)
Attachment #8702191 - Flags: review?(mcmanus) → review+
https://hg.mozilla.org/mozilla-central/rev/3c4344467351
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Blocks: 1253170
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: