1235305 - Block Lists dialog too small to read full text on Linux

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Nick Levinson]

The Block Lists dialog (Edit > Preferences > Privacy > Show Block List) is too narrow to display the full text and cannot be made wider. Either the text should auto-word-wrap or the dialog should auto-widen or be user-widenable.

Comment 1

[:Paolo Amadini]

Can you please post a screenshot of how the dialog appears on your computer?

Comment 2

[Nick Levinson]

Attachment: <Screenshot from 2015-12-31 12:22:34.png>. The "proper..." in it is truncated.

Here's the screenshot. It doesn't show the cursor, but the tip of it (I think that's the hot spot) was at the dialog's right edge, near the truncated text.

I misnamed the relevant button, which is Change Block List. Sorry; my fault.

Possibly this issue should be changed altogether, though: While the right edge can't be stretched from mid-edge, the lower right corner can be stretched rightward. So this problem becomes less important and instead perhaps the problem is that one or more dialogs fail to support right-edge-resizing, when other windows do, contradicting users' expectation.

Comment 3

[:Paolo Amadini]

Thanks for the screenshot. A simple solution may be for us to increase the default width by a couple of em's so we display it better on Linux.

Comment 4

[abhishekgarg119]

Hey i am new to mozilla and want to fix this bug. Can you please help me where to start to solve this bug?

Comment 5

[Marco Mucci [:MarcoM]]

(In reply to abhishekgarg119 from comment #4)
> Hey i am new to mozilla and want to fix this bug. Can you please help me
> where to start to solve this bug?

Hello there.  Thanks very much for your interest in working on this bug.  I'm sending a 'needinfo' to Panos, and ENG Manager on the team, who can guide you through this.

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Hello, as Paolo noted in comment 3 the simplest solution here is to bump the #dialogBox width by 2 em. The width is specified inline at blocklists.xul, but you will see that it is read from the blocklists.dtd file.

If you haven't built Firefox before, you will need to read the build instructions to get up to speed:

https://developer.mozilla.org/docs/Mozilla/Developer_guide/Build_Instructions

There is also a brand-new and quicker process that uses artifact builds, which you might want to try:

https://developer.mozilla.org/docs/Artifact_builds

You can find us on IRC in #fx-team if you need more help.

Comment 7

[abhishekgarg119]

i will be working on this bug, please assign it to me. Thanks.

Comment 8

[abhishekgarg119]

Attachment: Patch fixing this problem.

a patch to have better readability of message in firefox.

Comment 9

[YF (Yang)]

(In reply to abhishekgarg119 from comment #8)
> Created attachment 8721658 [details] [diff] [review]
> Patch fixing this problem.
> 
> a patch to have better readability of message in firefox.

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_reviewed

Comment 10

[abhishekgarg119]

Comment on attachment 8721658 [details] [diff] [review]
Patch fixing this problem.

Review of attachment 8721658 [details] [diff] [review]:
-----------------------------------------------------------------

The width of the window has been changed to improve readability of block lists message.

Comment 11

[YF (Yang)]

Comment on attachment 8721658 [details] [diff] [review]
Patch fixing this problem.

I'm not a component peer, :past appears review devtools only.
https://bugzilla.mozilla.org/page.cgi?id=review_suggestions.html#Firefox

Comment 12

[kaichun.shih(g3shihka)]

Attachment: Adding a patch

Patch that fixes this bug

Comment 13

[abhishekgarg119]

This bug has been assigned to me and i have already created a patch for it. Then why are you creating a duplicate patch with same changes?

Comment 14

[Justin Dolske [:Dolske]]

Comment on attachment 8721658 [details] [diff] [review]
Patch fixing this problem.

Review of attachment 8721658 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't verify this on Linux, but it does make the window bigger on OS X.

Comment 15

[Justin Dolske [:Dolske]]

(In reply to kaichun.shih(g3shihka) from comment #12)
> Created attachment 8723379 [details] [diff] [review]
> Adding a patch
> 
> Patch that fixes this bug

Hi Kaichun, unfortunately since abhishekgarg119 already had a patch up for this, we'll go with his fix (yours was the same, so it would have been fine too). Before working on a bug, it's best to make sure no one else is either assigned to it, or that there are no comments in the bug indicating it's being worked on by someone else. Better luck with your next bug, sorry!

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Please post an updated patch that includes proper commit information so this can land.

Comment 17

[abhishekgarg119]

Attachment: my.patch1

The patch has been updated with proper commit message.

Comment 18

[Panos Astithas (he/him) [:past] (please ni?)]

No need for another review, just mark it review+ yourself, but first edit the message to have r=dolske instead (no whitespace, use the IRC nick instead of the full name). Then set the checkin-needed keyword again for landing.

Comment 19

[Justin Dolske [:Dolske]]

Comment on attachment 8724667 [details] [diff] [review]
my.patch1

(No further review needed, see comment 18)

Comment 20

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9f8fd7e733820fb04befc988fc3c7aa3ee359870
Bug 1235305 - Increased the window width to improve readability of block lists message. rs=dolske

Comment 21

[Gian-Carlo Pascutto [:gcp]]

I upped this to 55em because I still saw some ellipsis on my machine with the old value. rs by dolske on IRC.

Comment 22

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9f8fd7e73382

Comment 23

[Paul Silaghi, QA [:pauly]]

Stepped over something else while testing this - https://drive.google.com/open?id=0By0_Tw9EIIVvYS1IM1JMN2pxVlE (linux only, not a regression)

Comment 24

[Paul Silaghi, QA [:pauly]]

Verified fixed FX 49.0a1 (2016-04-27) Win 7, Ubuntu 14.04, OS X 10.10.5