1235340 - [Z3C] Green/Flash images when playing FTU tutorial video with OpenMax PDM enabled.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[John Lin [:jhlin][:jolin]]

STR:
1. Goto 'Settings' > 'Developer'
2. Click 'Launch First Time Use'
3. Clicking 'Next' all the way to video tutorial page. The video will start playing, but it shows green image and flash.

Comment 1

[John Lin [:jhlin][:jolin]]

Currently OmxDataDecoder always disable/reenable port when receiving OMX_EventPortSettingsChanged event [1].
On Z3C, decoder will first generate OMX_EventPortSettingsChanged(nData2: OMX_IndexParamPortDefinition), and after the port is reenabled, it will generate another OMX_EventPortSettingsChanged(nData2: OMX_IndexConfigCommonOutputCrop), which causes OmxDataDecoder to disable/reenable the port again.

Stagefright addresses this by examining nData2 and not always disabling/reenabling the port [2].

[1] https://dxr.mozilla.org/mozilla-central/source/dom/media/platforms/omx/OmxDataDecoder.cpp?from=OmxDataDecoder.cpp#659
[2] https://android.googlesource.com/platform/frameworks/av/+/kitkat-release/media/libstagefright/ACodec.cpp#4241

Comment 2

[John Lin [:jhlin][:jolin]]

Attachment: Handle OMX_EventPortSettingsChanged like ACodec.

Comment 3

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8702828 [details] [diff] [review]
Handle OMX_EventPortSettingsChanged like ACodec.

Review of attachment 8702828 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good :)

Comment 4

[John Lin [:jhlin][:jolin]]

Attachment: Handle OMX_EventPortSettingsChanged like ACodec.

Carry r+ from sotaro.

Comment 5

[John Lin [:jhlin][:jolin]]

Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0eaf7d838189&selectedJob=15389840

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ab3c6ba63c89

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ab3c6ba63c89