1235380 - [GUI] remove modal dialogs in bisection

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[Julien Pagès (:parkouss)]

We have a couple of modal dialogs for the bisection process, I think it would be good to get rid of them.

It is necessary for the modal dialog that ask for build evaluation, because it prevent to see and scroll the logs in the log view.

Comment 1

[Julien Pagès (:parkouss)]

Attachment: remove bisection modal dialogs

These patches remove the modal dialogs. End of bisection is now logged only, and asking for a verdict is done in the report view. Bisecting further (on merge) is automatic, no popup to ask for it anymore.

Also now stopping a bisection do not clear the log view - only starting a new one do that.

Comment 2

[Julien Pagès (:parkouss)]

Attachment: mozscreen.png

Screen-shot to show how the verdict is asked now.

Comment 3

[MikeLing]

Comment on attachment 8702290 [details] [review]
remove bisection modal dialogs

It works good to me, I love it :)

Comment 4

[William Lachance (:wlach)]

Comment on attachment 8702290 [details] [review]
remove bisection modal dialogs

I don't really feel qualified to review this, but I approve of removing modal dialogs in general and nothing stood out as looking crazy. :)

Comment 5

[Julien Pagès (:parkouss)]

(In reply to William Lachance (:wlach) from comment #4)
> Comment on attachment 8702290 [details] [review]
> remove bisection modal dialogs
> 
> I don't really feel qualified to review this, but I approve of removing
> modal dialogs in general and nothing stood out as looking crazy. :)

Yes, I hear you; I'll try to ask for review people working on the GUI side of the project - starting with MikeLing, and hopefully there will be more later.

Thanks for the review and comment still!

Comment 6

[Julien Pagès (:parkouss)]

(In reply to MikeLing from comment #3)
> Comment on attachment 8702290 [details] [review]
> remove bisection modal dialogs
> 
> It works good to me, I love it :)

Thanks a lot for testing! And for the comment :)

Comment 7

[Julien Pagès (:parkouss)]

Landed in https://github.com/mozilla/mozregression/commit/54860a9c0ee280539594d81459e2e42eeb096981.