Closed Bug 1235472 Opened 8 years ago Closed 8 years ago

Remove uses of :-moz-full-screen-ancestor from gaia code

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: xidorn, Unassigned)

References

Details

Attachments

(2 files)

We are currently planing to remove :-moz-full-screen-ancestor pseudo-class (see bug 1199529).

I can see various places in gaia code are still using this pseudo-class which should be modified.

The majority of the uses are on #screen, which should be fixed via toggling a class on that element in mozfullscreenchange event like what we currently do on the top level #window for xul apps.

It also seems to me many of those uses are for promoting system UI on top of fullscreen element, which probably could be removed. (see bug 1235471)
Blocks: 1240434
No longer blocks: 1240434
I've created a PR for this issue.  https://github.com/mozilla-b2g/gaia/pull/34418
Comment on attachment 8790554 [details] [review]
Github PR#34418: Remove :-moz-full-screen-ancestor from gaia code

Thanks a lot!
Attachment #8790554 - Flags: review?(fabrice) → review+
https://github.com/mozilla-b2g/gaia/commit/2e148b4200be52c54da7f9e94b8b054f41655e3c
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Sorry, I made a mistake.  I've attached a second PR fixing that.  Apologies!
Please open a follow up bug for the new PR.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: