Closed Bug 1235518 Opened 9 years ago Closed 9 years ago

[TV][2.5][AppDeck] Show a confirm screen before deleting bookmark

Categories

(Firefox OS Graveyard :: Gaia::TV::Home, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::Home
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(feature-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)

Status:
VERIFIED FIXED
Project Flags:
feature-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-v2.5 --- fixed
b2g-master --- fixed

People

(Reporter: rexboy, Assigned: rexboy)

References

Details

(Whiteboard: [ft:conndevices][partner-blocker][partner-cherry-pick])

Attachments

(2 files)

[gaia] rexboy7:1235518 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
lchang
: review+
jocheng
: approval-gaia-v2.5+
Details | Review
[gaia] rexboy7:1235518-v2.5 > mozilla-b2g:v2.5
46 bytes, text/x-github-pull-request
Details | Review
We need a confirm dialog to let user confirm deleting bookmark.
Comment on attachment 8702869 [details] [review] [gaia] rexboy7:1235518 > mozilla-b2g:master Hi Luke: This patch adds confirm dialog. May you help review it?
Attachment #8702869 - Flags: review?(lchang)
Assignee: nobody → rexboy
Comment on attachment 8702869 [details] [review] [gaia] rexboy7:1235518 > mozilla-b2g:master r+ with only a few nits. Thanks.
Attachment #8702869 - Flags: review?(lchang) → review+
landed on master. https://github.com/mozilla-b2g/gaia/commit/8cd477527400d96d3e011ca95cdcfb01f8afde56
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8702869 [details] [review] [gaia] rexboy7:1235518 > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): follow-up of 1234163. [User impact] if declined: no confirmation dialog for deleting bookmark. [Testing completed]: done in local. [Risk to taking this patch] (and alternatives if risky): medium [String changes made]: yes, 3 keys.
Attachment #8702869 - Flags: approval-gaia-v2.5?
feature-b2g: --- → 2.5+
status-b2g-v2.5: --- → affected
status-b2g-master: --- → fixed
Comment on attachment 8702869 [details] [review] [gaia] rexboy7:1235518 > mozilla-b2g:master Approve for TV 2.5
Attachment #8702869 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
has problems to apply to 2.5 Tomcats-MacBook-Pro-2:gaia Tomcat$ git cherry-pick 94d9e88a9835cf4aaa62ffac4955be72ae6e5171 error: could not apply 94d9e88... Bug 1235518 - [TV][AppDeck] Show confirm dialog before deleting bookmarks hint: after resolving the conflicts, mark the corrected paths hint: with 'git add <paths>' or 'git rm <paths>' hint: and commit the result with 'git commit'
Flags: needinfo?(rexboy)
(In reply to KM Lee [:rexboy] from comment #9) > conflict solved & merged to v2.5: > https://github.com/mozilla-b2g/gaia/commit/ > f30c085106d98ce07b55a73fd82636861058b570 great thanks!
status-b2g-v2.5: affected → fixed
Verify this issue on the latest build. The dialog "Remove webpage from bookmarks?" will show up. [Build Info] Environment: 2.6 Simulator gaia: https://github.com/mozilla-b2g/gaia/commit/a6ecae635719115aa72465efe522fdced3dd1d70 gecko: https://hg.mozilla.org/mozilla-central/rev/af6356a3e8c56036b74ba097395356d9c6e6c5a3
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: