1235528 - Intermittent TEST-UNEXPECTED-FAIL | apps/homescreen/test/marionette/app_hosted_use_cached_icon_test.js | Homescreen - Hosted app cached icon fetch fallback to default icon

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [screenshot] failure state

When I disable the retry logic in bug 1222215, I see this test failing often (2 out of 5 times). Let's disable this test so it doesn't block bug 1222215.

TEST-UNEXPECTED-FAIL | apps/homescreen/test/marionette/app_hosted_use_cached_icon_test.js | Homescreen - Hosted app cached icon fetch fallback to default icon
Error: timeout exceeded!
    at Object.Client.waitForSync (node_modules/marionette-client/lib/marionette/client.js:760:16)
    at Object.Client.waitFor (node_modules/marionette-client/lib/marionette/client.js:726:60)
    at Object.Homescreen.waitForIconImageUrl (apps/homescreen/test/marionette/lib/homescreen.js:225:17)
    at Context.<anonymous> (apps/homescreen/test/marionette/app_hosted_use_cached_icon_test.js:57:10)
    at Test.MarionetteTest.run (node_modules/marionette-js-runner/lib/ui.js:25:31)
    at apps/homescreen/test/marionette/app_hosted_use_cached_icon_test.js:17:7
    at ChildProcess.<anonymous> (apps/homescreen/test/marionette/server/parent.js:187:5)
    at handleMessage (internal/child_process.js:686:10)
    at Pipe.channel.onread (internal/child_process.js:440:11)

https://treeherder.mozilla.org/logviewer.html#?job_id=3235191&repo=gaia

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

disabled in master: https://github.com/mozilla-b2g/gaia/commit/b0b8827815deeee644a757b7896e00817684ad45

Comment 2

[Chris Lord [:cwiiis]]

My best guess here is that we're not explicitly waiting for the cached icon to be stored, so it's possible to restart the homescreen before it gets a chance to store the icon in its icon cache.

Similar app_order_test, we (probably) need to wait for the app's metadata to include the icon before restarting the homescreen.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1235528-homescreen-app-hosted-use-cached-icon-test > mozilla-b2g:master

Comment 4

[Chris Lord [:cwiiis]]

Comment on attachment 8704660 [details] [review]
[gaia] Cwiiis:bug1235528-homescreen-app-hosted-use-cached-icon-test > mozilla-b2g:master

50 consecutive greens: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=82d7d797ae6cd4222d3f8707939a28b246686f2e

Comment 5

[Guillaume Marty [:gmarty]]

Comment on attachment 8704660 [details] [review]
[gaia] Cwiiis:bug1235528-homescreen-app-hosted-use-cached-icon-test > mozilla-b2g:master

Looks good!

Comment 6

[Chris Lord [:cwiiis]]

Merged: https://github.com/mozilla-b2g/gaia/commit/df9bda8e08ddf822dcc3b13ffb00deb901da63d9