Add a topobjdir variable to all Makefiles

RESOLVED FIXED in Firefox 46

Status

Firefox Build System
General
RESOLVED FIXED
2 years ago
3 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla46
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(6 attachments)

(Assignee)

Description

2 years ago
We have, all over the tree, several places that want absolute paths to the object directory, and most rely on things like $(abspath $(DIST)) or $(abspath $(DEPTH)), sometimes relying on even more complex things for windows paths. The sad part is that we do have the absolute path to the top object directory in the backend code (and in a proper form for windows, at that), we're just not exposing it to make.
(Assignee)

Comment 1

2 years ago
Created attachment 8702757 [details] [diff] [review]
Add a topobjdir variable to all Makefiles
Attachment #8702757 - Flags: review?(mshal)
(Assignee)

Comment 2

2 years ago
Created attachment 8702758 [details] [diff] [review]
Add a global ABS_DIST variable for a non-relative version of DIST, based on topobjdir

This replaces multiple local definitions of ABS_DIST.
Attachment #8702758 - Flags: review?(mshal)
(Assignee)

Comment 3

2 years ago
Created attachment 8702759 [details] [diff] [review]
Replace _ABS_DIST with ABS_DIST
Attachment #8702759 - Flags: review?(mshal)
(Assignee)

Comment 4

2 years ago
Created attachment 8702760 [details] [diff] [review]
Replace $(abspath $(DIST)) with $(ABS_DIST)
Attachment #8702760 - Flags: review?(mshal)
(Assignee)

Comment 5

2 years ago
Created attachment 8702762 [details] [diff] [review]
Replace $(abspath $(DEPTH)) with $(topobjdir)
Attachment #8702762 - Flags: review?(mshal)
(Assignee)

Comment 6

2 years ago
(In reply to Mike Hommey [:glandium] (VAC: 31 Dec - 11 Jan) from comment #5)
> Created attachment 8702762 [details] [diff] [review]
> Replace $(abspath $(DEPTH)) with $(topobjdir)

Note there's a remaining one in xulrunner/installer/windows/Makefile.in, but it's removed in bug 1235672
(Assignee)

Comment 7

2 years ago
Created attachment 8702796 [details] [diff] [review]
test_recursivemake.py update for topobjdir

This is to be folded in the first patch.
Attachment #8702796 - Flags: review?(mshal)
(Assignee)

Updated

2 years ago
Attachment #8702796 - Attachment is patch: true
Attachment #8702796 - Attachment mime type: text/x-patch → text/plain
(Assignee)

Updated

2 years ago
Blocks: 1235733

Updated

2 years ago
Blocks: 1235866
Comment on attachment 8702757 [details] [diff] [review]
Add a topobjdir variable to all Makefiles

Everything looks good to me. Did you test with an OSX universal build? That's the only place I can imagine something biting us.
Attachment #8702757 - Flags: review?(mshal) → review+

Updated

2 years ago
Attachment #8702758 - Flags: review?(mshal) → review+

Updated

2 years ago
Attachment #8702759 - Flags: review?(mshal) → review+

Updated

2 years ago
Attachment #8702760 - Flags: review?(mshal) → review+

Updated

2 years ago
Attachment #8702762 - Flags: review?(mshal) → review+
Comment on attachment 8702796 [details] [diff] [review]
test_recursivemake.py update for topobjdir

This should probably be folded in with the first patch.
Attachment #8702796 - Flags: review?(mshal) → review+

Updated

3 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.