Closed Bug 1235695 Opened 10 years ago Closed 9 years ago

Intermittent browser_940946_removable_from_navbar_customizemode.js | Test timed out

Categories

(Firefox :: Toolbars and Customization, defect)

Product:
Firefox
Component:
Toolbars and Customization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 50
Tracking Flags:
Tracking Status
firefox48 --- fixed
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: philor, Assigned: Gijs)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1235695, bug 1277270 - fix e10s test issues,
58 bytes, text/x-review-board-request
jaws
: review+
Details
This is a pretty frequent Windows e10s intermittent. Any chance you could take a look at this at some point, Gijs?
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #14) > This is a pretty frequent Windows e10s intermittent. Any chance you could > take a look at this at some point, Gijs? Yes, but I'm only here half a day today, so it might not be today, in which case I'm off until Tuesday... so likely no immediate release, sorry. Will leave needinfo.
(In reply to :Gijs Kruitbosch from comment #15) > (In reply to Ryan VanderMeulen [:RyanVM] from comment #14) > > This is a pretty frequent Windows e10s intermittent. Any chance you could > > take a look at this at some point, Gijs? > > Yes, but I'm only here half a day today, so it might not be today, in which > case I'm off until Tuesday... so likely no immediate release, sorry. Will > leave needinfo. All of the orange from the past two weeks seems to be non-e10s. Am I missing something? Or is this stopping us from enabling the windows 8 e10s things again or something? (Going to keep my needinfo and look at it a bit more anyway.)
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(ryanvm)
Flags: needinfo?(gijskruitbosch+bugs)
You're right, I have no idea where I got e10s from on this. Sorry for the confusion.
I can't reproduce this locally, not even on a debug build, not even when running the entire directory, and the test itself is trivial so I have no idea what's failing. It's supposed to open customize mode, then close customize mode. The screenshots look like it's stuck opening customize mode It's likely due to some earlier test, or something - but even then it's not clear what that is. No errors in the logs, either, which isn't helpful. I also looked at the pushlog around the time this got filed and saw nothing that strikes me as immediately relevant. It looks like this is comparatively far down on orangefactor, so I will try to focus on more high-impact things for now. Feel free to ping me again if you think I've missed something.
Flags: needinfo?(gijskruitbosch+bugs)
Flags: needinfo?(ryanvm)
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to :Gijs Kruitbosch from comment #33) > remote: > https://treeherder.mozilla.org/#/jobs?repo=try&revision=514c86ac2494 This worked, so it looks like that popup in the corner of the screenshots for this failing test is indeed the problem. More fix-style fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cab642bb6e32 (FWIW, if we disable this test it'll likely just break the test after it).
(In reply to :Gijs Kruitbosch from comment #35) > (In reply to :Gijs Kruitbosch from comment #33) > > remote: > > https://treeherder.mozilla.org/#/jobs?repo=try&revision=514c86ac2494 > > This worked, so it looks like that popup in the corner of the screenshots > for this failing test is indeed the problem. More fix-style fix: > > https://treeherder.mozilla.org/#/jobs?repo=try&revision=cab642bb6e32 > > (FWIW, if we disable this test it'll likely just break the test after it). \o/ Only issue... I can't really tell if fixing this might make bug 1277270 so frequent that we'll need to fix that in order to land this. So I took a stab (I was kind of waiting for mconley in bug 1277270 but I think he's on PTO). remote: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc336c32691f
I forgot win32 vs mac is relevant here, better patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a01fb7f9ad87
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #8763624 - Flags: review?(jaws) → review+
Comment on attachment 8763624 [details] Bug 1235695, bug 1277270 - fix e10s test issues, https://reviewboard.mozilla.org/r/59798/#review56976 ::: browser/components/customizableui/test/browser_947914_button_print.js:11 (Diff revision 1) > > const isOSX = (Services.appinfo.OS === "Darwin"); > > add_task(function*() { > info("Check print button existence and functionality"); > + yield BrowserTestUtils.openNewForegroundTab(gBrowser, "http://example.com/"); Can you use BrowserTestUtils.withNewTab here instead so the closing of it is guaranteed?
Comment on attachment 8763624 [details] Bug 1235695, bug 1277270 - fix e10s test issues, Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59798/diff/1-2/
https://hg.mozilla.org/mozilla-central/rev/b5255021899d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Blocks: 1277270
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: