1235697 - [Z3C][CBS] Not able to disable the Cell Broadcast

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

[Blocking Requested - why for this release]:
Annoying and abnormal Cell broadcast messages for the foxfooding users.

This is a follow-up of bug 987233 comment 18.
As verified in bug 987233 comment 19 and bug 987233 comment 19, it seems that there is something wrong in Z3C's base image which prevents us to disable the Cell Broadcast function properly.

This bug is to provide a workaround to double check the settings before notifying the received CB message to the user.

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Hi,

As mentioned in comment 0, it seems that the Z3C firmware didn't allow FoxOS to disable the cellbroadcast properly.

Our workaround for now is to ensure the "Disable" function works in Z3C by double check the settings before notifying the received CB messages to the user.
Do you still need the messages from channel 50 to be displayed gracefully(Which is not available in current UX design) or the "Disable" function will be good enough for you?

Comment 2

[methwanishagufta]

Thank you for creating this bug. I dont think these messages have any significance and need to be displayed at all. Disabling should be fine.

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c558c54739d5

Comment 4

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v1) Part 1: Workaround to Suppress the CB Message according to the settings.

Hi Edgar,

May I have your review for this change?

Thanks!

Comment 5

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v1) Part 2: Add Test Coverage.

Comment 6

[Edgar Chen [:edgar]]

Comment on attachment 8702866 [details] [diff] [review]
(v1) Part 2: Add Test Coverage.

Review of attachment 8702866 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.

Comment 7

[Bevis Tseng[:bevis][:btseng](Exited)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1805ddbbfacc

Comment 8

[Bevis Tseng[:bevis][:btseng](Exited)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a5b1d9fc18d

Comment 9

[Bevis Tseng[:bevis][:btseng](Exited)]

tryserver result is provided in comment 7.

Note: There is depdendency to bug 1235110 because the change of both bugs has been done in the same function.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/7d3749d5c0b9
https://hg.mozilla.org/integration/b2g-inbound/rev/32b8e75ba600

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7d3749d5c0b9
https://hg.mozilla.org/mozilla-central/rev/32b8e75ba600

Comment 12

[Hsin-Yi Tsai (she/her) away [:hsinyi]]

Per the drivers meeting this week, we won't uplift to v2.5 if it's a non-TV blocker. Cancelling the  flag.