1235712 - Hard to select version text on about dialog after bug 1047395

Status: RESOLVED WONTFIX

(Firefox :: General, defect)

Description

[YF (Yang)]

Attachment: After the hot zone

https://hg.mozilla.org/mozilla-central/rev/a88f7cf06080#l2.12 added a hbox. I don't know the reason for it, but it lead to the label loss empty space on the right side, it will difficult to select it from the right.

Comment 1

[YF (Yang)]

Attachment: Before the hot zone (if removed the hbox)

Comment 2

[YF (Yang)]

Uh, I just see attachment 8694133 [details], perhaps it is necessary, but this needs a better handle for the mouse to select all.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Sure, why not but I will need help to address this. Florian, do you know how we can manage that?

Comment 4

[Florian Quèze [:florian]]

I'm not sure what's the exact problem here. Isn't a triple click on the version number enough to select all of it?

Comment 5

[YF (Yang)]

(In reply to Florian Quèze [:florian] [:flo] from comment #4)
> I'm not sure what's the exact problem here. Isn't a triple click on the
> version number enough to select all of it?

No, it once allow drag from the right side to select all the text, but now it is a compact text box. The triple click or focus and Ctrl+A is not a common/convenient operations. Stated another way, that weakens a known operations.


Maybe it can output the hbox when necessary, but this is still a problem for the users to select when a text box and link shown.

Comment 6

[Florian Quèze [:florian]]

I'm not sure I understand the request here. I don't see any way to improve this when the 'what's new' link is shown. Are you suggesting we revert to the previous behavior only for the Nightly case (where the 'What's new' link isn't shown and users reporting bugs are more likely to want to copy the version number that includes the build day)?

Comment 7

[Sylvestre Ledru [:Sylvestre]]

FYI, about:support provides the same information.

Comment 8

[YF (Yang)]

(In reply to Florian Quèze [:florian] [:flo] from comment #6)
> I'm not sure I understand the request here. I don't see any way to improve
> this when the 'what's new' link is shown. Are you suggesting we revert to
> the previous behavior only for the Nightly case (where the 'What's new' link
> isn't shown and users reporting bugs are more likely to want to copy the
> version number that includes the build day)?

Maybe can give a blank / margin to the right side, facilitate the selection of the text box.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

As Florian explained in comment #6, I don't see the point of spending time on this.

Comment 10

[YF (Yang)]

Attachment: Apply the padding-right

Like apply the "#version {padding-right: 80px;}".

Comment 11

[Sylvestre Ledru [:Sylvestre]]

YF, I guess you are going to propose a patch?

Comment 12

[YF (Yang)]

I hope but don't want to make a patch temporary, I can't see the link in the about window in Nightly, so I manually add the element  to simulate it. I think I did not fully understand it.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

I don't think we are going to provide a fix for that, we should just won't fix it as it is not a big deal.