Closed Bug 1235802 Opened 4 years ago Closed 4 years ago

Intermittent TEST-UNEXPECTED-FAIL | apps/system/test/marionette/app_window_mananger_pinned_sites_test.js | AppWindowManager - Pinning sites Pinning unscoped "before each" hook for "Tapping the browser opens the last unpinned instance"

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.6 S5 - 1/15

People

(Reporter: mikehenrty, Assigned: mikehenrty)

Details

(Keywords: intermittent-failure, Whiteboard: [systemsfe][MJS])

Attachments

(2 files)

Looks like another PinningTheWeb.openAndPinSiteFromBrowser related timeout:

TEST-UNEXPECTED-FAIL | apps/system/test/marionette/app_window_mananger_pinned_sites_test.js | AppWindowManager - Pinning sites Pinning unscoped "before each" hook for "Tapping the browser opens the last unpinned instance"
Error: timeout exceeded!
    at Object.Client.waitForSync (node_modules/marionette-client/lib/marionette/client.js:760:16)
    at Object.Client.waitFor (node_modules/marionette-client/lib/marionette/client.js:726:60)
    at Object.MarionetteHelper.waitForElement (node_modules/marionette-helper/index.js:142:12)
    at Object.pinDialog (apps/system/test/marionette/lib/pinning_the_web.js:21:31)
    at Object.openAndPinSite [as openAndPinSiteFromBrowser] (apps/system/test/marionette/lib/pinning_the_web.js:77:54)
    at pinAndKill (apps/system/test/marionette/app_window_mananger_pinned_sites_test.js:37:13)
    at Context.<anonymous> (apps/system/test/marionette/app_window_mananger_pinned_sites_test.js:75:7)

https://treeherder.mozilla.org/logviewer.html#?job_id=3241230&repo=gaia
Comment on attachment 8703078 [details] [review]
[gaia] mikehenrty:bug-1235802-pinning-library-fix > mozilla-b2g:master

Looking pretty green now: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=26508a76835d
Attachment #8703078 - Flags: review?(gmarty)
Comment on attachment 8703078 [details] [review]
[gaia] mikehenrty:bug-1235802-pinning-library-fix > mozilla-b2g:master

LGTM!
Attachment #8703078 - Flags: review?(gmarty) → review+
master: https://github.com/mozilla-b2g/gaia/commit/48458b9d7c783d2acebcea7487a0b7fe7a3d71dc
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Assignee: nobody → mhenretty
Target Milestone: --- → 2.6 S5 - 1/15
You need to log in before you can comment on or make changes to this bug.