1235802 - Intermittent TEST-UNEXPECTED-FAIL | apps/system/test/marionette/app_window_mananger_pinned_sites_test.js | AppWindowManager - Pinning sites Pinning unscoped "before each" hook for "Tapping the browser opens the last unpinned instance"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [screenshot] failure state

Looks like another PinningTheWeb.openAndPinSiteFromBrowser related timeout:

TEST-UNEXPECTED-FAIL | apps/system/test/marionette/app_window_mananger_pinned_sites_test.js | AppWindowManager - Pinning sites Pinning unscoped "before each" hook for "Tapping the browser opens the last unpinned instance"
Error: timeout exceeded!
    at Object.Client.waitForSync (node_modules/marionette-client/lib/marionette/client.js:760:16)
    at Object.Client.waitFor (node_modules/marionette-client/lib/marionette/client.js:726:60)
    at Object.MarionetteHelper.waitForElement (node_modules/marionette-helper/index.js:142:12)
    at Object.pinDialog (apps/system/test/marionette/lib/pinning_the_web.js:21:31)
    at Object.openAndPinSite [as openAndPinSiteFromBrowser] (apps/system/test/marionette/lib/pinning_the_web.js:77:54)
    at pinAndKill (apps/system/test/marionette/app_window_mananger_pinned_sites_test.js:37:13)
    at Context.<anonymous> (apps/system/test/marionette/app_window_mananger_pinned_sites_test.js:75:7)

https://treeherder.mozilla.org/logviewer.html#?job_id=3241230&repo=gaia

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] mikehenrty:bug-1235802-pinning-library-fix > mozilla-b2g:master

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8703078 [details] [review]
[gaia] mikehenrty:bug-1235802-pinning-library-fix > mozilla-b2g:master

Looking pretty green now: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=26508a76835d

Comment 3

[Guillaume Marty [:gmarty]]

Comment on attachment 8703078 [details] [review]
[gaia] mikehenrty:bug-1235802-pinning-library-fix > mozilla-b2g:master

LGTM!

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/48458b9d7c783d2acebcea7487a0b7fe7a3d71dc

Comment 5

[Intermittent Failures Robot]

18 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 9
* gaia: 4
* b2g-inbound: 3
* fx-team: 2

Platform breakdown:
* mulet-linux64: 8
* b2g-linux64: 6
* gaia: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1235802&startday=2015-12-28&endday=2016-01-03&tree=all