Closed Bug 1235859 Opened 4 years ago Closed 4 years ago
Size to non-skia downscaler
Bug 1229825 calls DownScaler FrameSize() which is not defined in the non-skia version of the downscaler.
Review commit: https://reviewboard.mozilla.org/r/29233/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/29233/
Attachment #8702950 - Flags: review?(edwin)
Comment on attachment 8702950 [details] MozReview Request: Bug 1235859 - Add FrameSize to non-skia downscaler. r?eflores https://reviewboard.mozilla.org/r/29233/#review26029 Slightly surprised 0 casts to an nsIntSize, but *shrug*.
Attachment #8702950 - Flags: review?(edwin) → review+
Review commit: https://reviewboard.mozilla.org/r/29237/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/29237/
I've updated the patch to do nsIntSize(0,0);
Assignee: nobody → steve
Status: NEW → ASSIGNED
Comment on attachment 8703049 [details] [diff] [review] 1235859.diff Approval Request Comment [Feature/regressing bug #]: Bug 1229825. [User impact if declined]: Breaks non-skia builds. [Describe test coverage new/current, TreeHerder]: Builds properly now. [Risks and why]: None. [String/UUID change made/needed]: None.
Comment on attachment 8703049 [details] [diff] [review] 1235859.diff I am told that this uplift will not have any impact on Firefox official builds. Beta44+, Aurora45+
You need to log in before you can comment on or make changes to this bug.