Closed Bug 1235859 Opened 4 years ago Closed 4 years ago

Add FrameSize to non-skia downscaler

Categories

(Core :: Graphics, defect)

44 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox44 --- fixed
firefox45 --- fixed
firefox46 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: stevensn, Assigned: stevensn)

Details

Attachments

(1 file, 3 obsolete files)

Bug 1229825 calls DownScaler FrameSize() which is not defined in the non-skia version of the downscaler.
Comment on attachment 8702950 [details]
MozReview Request: Bug 1235859 - Add FrameSize to non-skia downscaler. r?eflores

https://reviewboard.mozilla.org/r/29233/#review26029

Slightly surprised 0 casts to an nsIntSize, but *shrug*.
Attachment #8702950 - Flags: review?(edwin) → review+
I've updated the patch to do nsIntSize(0,0);
Assignee: nobody → steve
Status: NEW → ASSIGNED
Attached patch 1235859.diffSplinter Review
Attachment #8702950 - Attachment is obsolete: true
Attachment #8702975 - Attachment is obsolete: true
Attachment #8703048 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8418f85a3b17
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Comment on attachment 8703049 [details] [diff] [review]
1235859.diff

Approval Request Comment
[Feature/regressing bug #]: Bug 1229825.
[User impact if declined]: Breaks non-skia builds.
[Describe test coverage new/current, TreeHerder]: Builds properly now.
[Risks and why]: None.
[String/UUID change made/needed]: None.
Attachment #8703049 - Flags: approval-mozilla-beta?
Attachment #8703049 - Flags: approval-mozilla-aurora?
Comment on attachment 8703049 [details] [diff] [review]
1235859.diff

I am told that this uplift will not have any impact on Firefox official builds. Beta44+, Aurora45+
Attachment #8703049 - Flags: approval-mozilla-beta?
Attachment #8703049 - Flags: approval-mozilla-beta+
Attachment #8703049 - Flags: approval-mozilla-aurora?
Attachment #8703049 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.