1235859 - Add FrameSize to non-skia downscaler

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Steve Singer (:stevensn)]

Bug 1229825 calls DownScaler FrameSize() which is not defined in the non-skia version of the downscaler.

Comment 1

[Steve Singer (:stevensn)]

Attachment: MozReview Request: Bug 1235859 - Add FrameSize to non-skia downscaler. r?eflores

Review commit: https://reviewboard.mozilla.org/r/29233/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29233/

Comment 2

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8702950 [details]
MozReview Request: Bug 1235859 - Add FrameSize to non-skia downscaler. r?eflores

https://reviewboard.mozilla.org/r/29233/#review26029

Slightly surprised 0 casts to an nsIntSize, but *shrug*.

Comment 3

[Steve Singer (:stevensn)]

Attachment: MozReview Request: Bug 1235859 - Add FrameSize to non-skia downscaler.

Review commit: https://reviewboard.mozilla.org/r/29237/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29237/

Comment 4

[Steve Singer (:stevensn)]

I've updated the patch to do nsIntSize(0,0);

Comment 5

[Steve Singer (:stevensn)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=013a485e9ff7

Comment 6

[Steve Singer (:stevensn)]

Attachment: Add FrameSize to non-skia downscaler

Comment 7

[Steve Singer (:stevensn)]

Attachment: 1235859.diff

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8418f85a3b17

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8418f85a3b17

Comment 10

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8703049 [details] [diff] [review]
1235859.diff

Approval Request Comment
[Feature/regressing bug #]: Bug 1229825.
[User impact if declined]: Breaks non-skia builds.
[Describe test coverage new/current, TreeHerder]: Builds properly now.
[Risks and why]: None.
[String/UUID change made/needed]: None.

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8703049 [details] [diff] [review]
1235859.diff

I am told that this uplift will not have any impact on Firefox official builds. Beta44+, Aurora45+

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c28406c57e3a

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/906fc0cacd8d

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/906fc0cacd8d