Add FrameSize to non-skia downscaler

RESOLVED FIXED in Firefox 44, Firefox OS v2.5

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: stevensn, Assigned: stevensn)

Tracking

44 Branch
mozilla46
Points:
---

Firefox Tracking Flags

(firefox44 fixed, firefox45 fixed, firefox46 fixed, b2g-v2.5 fixed)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

3 years ago
Bug 1229825 calls DownScaler FrameSize() which is not defined in the non-skia version of the downscaler.
(Assignee)

Comment 1

3 years ago
Created attachment 8702950 [details]
MozReview Request: Bug 1235859 - Add FrameSize to non-skia downscaler. r?eflores

Review commit: https://reviewboard.mozilla.org/r/29233/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29233/
Attachment #8702950 - Flags: review?(edwin)
Comment on attachment 8702950 [details]
MozReview Request: Bug 1235859 - Add FrameSize to non-skia downscaler. r?eflores

https://reviewboard.mozilla.org/r/29233/#review26029

Slightly surprised 0 casts to an nsIntSize, but *shrug*.
Attachment #8702950 - Flags: review?(edwin) → review+
(Assignee)

Comment 3

3 years ago
Created attachment 8702975 [details]
MozReview Request: Bug 1235859 - Add FrameSize to non-skia downscaler.

Review commit: https://reviewboard.mozilla.org/r/29237/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29237/
(Assignee)

Comment 4

3 years ago
I've updated the patch to do nsIntSize(0,0);
(Assignee)

Comment 6

3 years ago
Created attachment 8703048 [details] [diff] [review]
Add FrameSize to non-skia downscaler
(Assignee)

Updated

3 years ago
Assignee: nobody → steve
Status: NEW → ASSIGNED
(Assignee)

Comment 7

3 years ago
Created attachment 8703049 [details] [diff] [review]
1235859.diff
Attachment #8702950 - Attachment is obsolete: true
Attachment #8702975 - Attachment is obsolete: true
Attachment #8703048 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 9

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8418f85a3b17
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Comment on attachment 8703049 [details] [diff] [review]
1235859.diff

Approval Request Comment
[Feature/regressing bug #]: Bug 1229825.
[User impact if declined]: Breaks non-skia builds.
[Describe test coverage new/current, TreeHerder]: Builds properly now.
[Risks and why]: None.
[String/UUID change made/needed]: None.
Attachment #8703049 - Flags: approval-mozilla-beta?
Attachment #8703049 - Flags: approval-mozilla-aurora?
Comment on attachment 8703049 [details] [diff] [review]
1235859.diff

I am told that this uplift will not have any impact on Firefox official builds. Beta44+, Aurora45+
Attachment #8703049 - Flags: approval-mozilla-beta?
Attachment #8703049 - Flags: approval-mozilla-beta+
Attachment #8703049 - Flags: approval-mozilla-aurora?
Attachment #8703049 - Flags: approval-mozilla-aurora+

Updated

3 years ago
status-firefox44: --- → affected
status-firefox45: --- → affected

Comment 12

3 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/c28406c57e3a
status-firefox45: affected → fixed

Comment 13

3 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/906fc0cacd8d
status-firefox44: affected → fixed
You need to log in before you can comment on or make changes to this bug.