Closed
Bug 1235859
Opened 8 years ago
Closed 8 years ago
Add FrameSize to non-skia downscaler
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla46
People
(Reporter: stevensn, Assigned: stevensn)
Details
Attachments
(1 file, 3 obsolete files)
889 bytes,
patch
|
ritu
:
approval-mozilla-aurora+
ritu
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Bug 1229825 calls DownScaler FrameSize() which is not defined in the non-skia version of the downscaler.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/29233/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/29233/
Attachment #8702950 -
Flags: review?(edwin)
Comment on attachment 8702950 [details] MozReview Request: Bug 1235859 - Add FrameSize to non-skia downscaler. r?eflores https://reviewboard.mozilla.org/r/29233/#review26029 Slightly surprised 0 casts to an nsIntSize, but *shrug*.
Attachment #8702950 -
Flags: review?(edwin) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/29237/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/29237/
Assignee | ||
Comment 4•8 years ago
|
||
I've updated the patch to do nsIntSize(0,0);
Assignee | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=013a485e9ff7
Assignee | ||
Comment 6•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → steve
Status: NEW → ASSIGNED
Assignee | ||
Comment 7•8 years ago
|
||
Attachment #8702950 -
Attachment is obsolete: true
Attachment #8702975 -
Attachment is obsolete: true
Attachment #8703048 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8418f85a3b17
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Comment on attachment 8703049 [details] [diff] [review] 1235859.diff Approval Request Comment [Feature/regressing bug #]: Bug 1229825. [User impact if declined]: Breaks non-skia builds. [Describe test coverage new/current, TreeHerder]: Builds properly now. [Risks and why]: None. [String/UUID change made/needed]: None.
Attachment #8703049 -
Flags: approval-mozilla-beta?
Attachment #8703049 -
Flags: approval-mozilla-aurora?
Comment on attachment 8703049 [details] [diff] [review] 1235859.diff I am told that this uplift will not have any impact on Firefox official builds. Beta44+, Aurora45+
Attachment #8703049 -
Flags: approval-mozilla-beta?
Attachment #8703049 -
Flags: approval-mozilla-beta+
Attachment #8703049 -
Flags: approval-mozilla-aurora?
Attachment #8703049 -
Flags: approval-mozilla-aurora+
status-firefox44:
--- → affected
status-firefox45:
--- → affected
Comment 12•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/c28406c57e3a
Comment 13•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/906fc0cacd8d
Comment 14•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/906fc0cacd8d
status-b2g-v2.5:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•