1235977 - [TV][2.5] Video can't be played in the preview mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV::System, defect)

Description

[Luke Chang [:lchang] (inactive)]

Video can't be played in the preview mode from Marketplace but can be played when you add it to Apps.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] luke-chang:1235977_tv_preview_window_audio_policy > mozilla-b2g:master

Comment 2

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8703070 [details] [review]
[gaia] luke-chang:1235977_tv_preview_window_audio_policy > mozilla-b2g:master

Hi Rex,

Could you please review this patch? Thanks.

The root cause is related to Audio Channel Policy. When we was trying to migrate that feature from phone to TV, we found that HierarchyManager was missing from TV system so we had to workaround it by using FocusManager instead. Since they're not identical, it needs us to specify which "class" should be handled by Audio Channel Policy modules in our workaround and we specified "AppWindow" only at that time.

In this patch, I added "PreviewWindow" and "PopupWindow" to the white list so AudioChannelService can handle them well now.

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8703070 [details] [review]
[gaia] luke-chang:1235977_tv_preview_window_audio_policy > mozilla-b2g:master

Looks good to me. thanks.

Comment 4

[Luke Chang [:lchang] (inactive)]

tests passed: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=33ce0ba96e69259f300d2f0025236133ac6b341a

landed on master: https://github.com/mozilla-b2g/gaia/commit/cc60869361f804350bc2b65605adda3e4e0d4bd3

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8703070 [details] [review]
[gaia] luke-chang:1235977_tv_preview_window_audio_policy > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): feature: TV OWD
[User impact] if declined: all video can't be played.
[Testing completed]: yes.
[Risk to taking this patch] (and alternatives if risky): low.
[String changes made]: N/A

Comment 6

[Josh Cheng [:josh]]

Comment on attachment 8703070 [details] [review]
[gaia] luke-chang:1235977_tv_preview_window_audio_policy > mozilla-b2g:master

Approve for TV 2.5

Comment 7

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/fd60843b9453039d33ad77ac769414e18b50c0e9

Comment 8

[[e-mail]]

Verify this issue on the latest build.
Video can be played from Marketplace directly without adding it to Apps.

[Build Info]
simulator 2.6.20160222133739
gaia:
https://github.com/mozilla-b2g/gaia/commit/d9faad5c0f14fcd42f920c9104f0638f46a48b2a
gecko:
https://hg.mozilla.org/mozilla-central/rev/789a12291942763bc1e3a89f97e0b82dc1c9d00b