1236051 - accessible name from multiple label elements missing white space

Status: NEW

(Firefox :: Disability Access, defect)

Description

[steve faulkner]

When multiple <label> elements are associated with a labelable elment, the accessible name should be the product of the text content of each of the labels concatenated by DOM source order and space separated.

Firefox outputs the concatenated accessible names from multiple label elments, but does not put a space between the text strings.
http://rawgit.com/w3c/aria/master/html-aam/html-aam.html#input-type-text-input-type-password-input-type-search-input-type-tel-input-type-url-and-textarea-element

For the test file:
http://thepaciellogroup.github.io/AT-browser-tests/test-files/label2.html

the expected accessible name is
"name First name only"

the accessible name produced is
"nameFirst name only"

Comment 1

[Momdo Nakamura]

The latest spec is here:
https://w3c.github.io/html-aam/#input-type-text-input-type-password-input-type-search-input-type-tel-input-type-email-input-type-url-and-textarea-element-accessible-name-computation

Comment 2

[virenv]

Hello everyone,
I am new to firefox. I would like to fix this bug. Is it available yet?

My initial analysis shows that we would have to fix the code somewhere here: nsTextEquivUtils::AppendFromAccessible.
I can debug this further if the bug is available.

Comment 3

[virenv]

I did little digging into the code and found that we explicitly trim spaces here: ENameValueFlag Accessible::NativeName(nsString& aName)

With best of my early-stage understanding, if we simply change the method to do this:
ENameValueFlag Accessible::NativeName(nsString& aName) const {
if (mContent->IsHTMLElement()) {
Accessible* label = nullptr;
HTMLLabelIterator iter(Document(), this);
while ((label = iter.Next())) {
nsTextEquivUtils::AppendTextEquivFromContent(this, label->GetContent(),
&aName);
aName.Append(L" ");
}

if (!aName.IsEmpty()) {
  aName.CompressWhitespace();
  return eNameOK;
}

We should be able to fix the issue.

Please assign this bug to me, I will try to come up with a correct solution.

Comment 5

[Johncena]

Hey
Firefox is new to me. I will correct this error. Is it there?

My initial analysis indicated that we needed to fix the code here: nsTextEquivUtils :: AppendiceFromAccessible.
I can fix more if there is a mistake.

Comment 7

[John Markos]

Users often access HTML content using assistive technologies that rely on platform accessibility API to obtain and interact with information from the page. This document is part of the following suite of accessibility API mapping specifications for content rendered by user agents:
Synapse X Synapse X Optifine

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:asa, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 12

[Denis Kisavi (:kisavi)]

Hello @apkwa. Has this bug been solved?

Comment 15

[Marco Zehe (:MarcoZ)]

I was just contacted about this bug. However, since I am no longer a member of the Mozilla accessibility team and no longer employed at Mozilla, redirecting the mentorship to Jamie so as to avoid future confusion. I have also informed the person contacting me about this.

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit BugBot documentation.