Closed Bug 1236053 Opened 9 years ago Closed 9 years ago

Remove the filtering functionality from the Tree component

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(firefox46 fixed)

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file)

In practice, we filter trees off-main-thread in a worker and the tree that we pass to the Tree component is already filtered, which is a better architecture anyways. Additionally, we lack any kind of tests for the Tree component's built-in filtering. And finally, there isn't even a single user of the built-in filtering functionality. Dead it!
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Depends on: 1235933
Comment on attachment 8703164 [details] [diff] [review] Remove the filtering functionality from the Tree component Review of attachment 8703164 [details] [diff] [review]: ----------------------------------------------------------------- lgtm!
Attachment #8703164 - Flags: review?(jsantell) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
[bugday-20160323] Status: RESOLVED,FIXED -> UNVERIFIED Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: