1236110 - Extend mach artifact to handle Linux Desktop builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

This is like Bug 1207890, but for Linux builds.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1236110 - Extend mach artifact to handle Linux Desktop builds. r?gps

Review commit: https://reviewboard.mozilla.org/r/29837/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29837/

Comment 2

[Nick Alexander :nalexander [he/him]]

(In reply to Nick Alexander :nalexander from comment #1)
> Created attachment 8704970 [details]
> MozReview Request: Bug 1236110 - Extend mach artifact to handle Linux
> Desktop builds. r?gps
> 
> Review commit: https://reviewboard.mozilla.org/r/29837/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/29837/

kmaglione, chmanchester -- I think y'all are both Linux users.  This builds on top of some Windows work that hasn't quite landed, but if you could test this and report back I'd appreciate.  Thanks!

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Works beautifully. I noticed I need to pull from fx-team for this to work, we could probably find a way detect what tree the local repository is based on.

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8704970 [details]
MozReview Request: Bug 1236110 - Extend mach artifact to handle Linux Desktop builds. r?gps

https://reviewboard.mozilla.org/r/29837/#review26771

LGTM!

::: python/mozbuild/mozbuild/artifacts.py:148
(Diff revision 1)
> +                    whitelist = {
> +                        'crashreporter',
> +                        'dependentlibs.list',
> +                        'firefox',
> +                        'firefox-bin',
> +                        'plugin-container',
> +                        'updater',
> +                        'webapprt-stub',
> +                    }

Let's declare this outside the loop so it doesn't need to be re-evaluated.

::: python/mozbuild/mozbuild/artifacts.py:157
(Diff revision 1)
> +                    if not basename.endswith('.so') and \
> +                       not basename in whitelist:

Please use `basename not in whitelist` instead of `not x in y`.

Comment 5

[Kris Maglione [:kmag]]

I eventually managed to get this working, but I ran into some problems along
the way:

I get this error from `mach configure`:

 0:04.47 /home/kris/code/mozilla-central/configure: line 22347: -E: command not found

Which corresponds to the second line of:

    *:x86_64)
      if $CC -E -dM -</dev/null | grep -q __ELF__; then
        VPX_ASFLAGS="-f elf64 -rnasm -pnasm -DPIC"
        VPX_X86_ASM=1
      fi
    ;;

I don't think this causes any problems, but it's confusing when you're trying
to track down errors.


I realized that my first problem was that I needed to manually enable the
mozext extension (I had the impression that mercurial-config would do this for
me).


After that, I got this error from configure:

 0:24.94  0:08.61 Installing from local revision fa077489e763b5cc5f547868d3be33cd7aa3c987
 0:25.88  0:09.56 No built artifacts for fa077489e763b5cc5f547868d3be33cd7aa3c987 found.
 ...
 0:25.94 subprocess.CalledProcessError: Command '['/home/kris/code/mozilla-central/objdir-artifact/_virtualenv/bin/python', '/home/kris/code/mozilla-central/mach', 'artifact', 'install']' returned non-zero exit status 1

I eventually figured out that I needed to pull from fx-team again *after*
having enabled mozext. That still didn't fix the problem, though, until I
removed pushheads-cache.pickle and artifact_url-cache.pickle.


So I think you should make your instructions as clear as possible, because
those problems weren't easy to figure out.


After that, everything worked beautifully, as far as building and running
Firefox. Mochitests don't work, because of missing utilities, but I think
that's still expected.

Comment 6

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/e5948d63bfb609938e3e912341c396c1a0f055cb
Bug 1236110 - Extend mach artifact to handle Linux Desktop builds. r=gps

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e5948d63bfb6