Complete test coverage for the WebExtension cookies API.

RESOLVED FIXED in Firefox 48

Status

()

Toolkit
WebExtensions: Untriaged
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: kmag, Assigned: bsilverberg)

Tracking

unspecified
mozilla48
Points:
---
Dependency tree / graph
Bug Flags:
blocking-webextensions +

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: [test] triaged)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

There's a lot of missing coverage in the |query| function, in particular:

* Selecting an enumerator for queries with no |url| or |domain| filter.
* Matching and non-matching cookies for the |domain|, |path|, |secure|, |session|, and |storeId| filters.
* Non-matching cookies for the domain and path portions of the |url| filter.
* Failing |checkSetCookiePermissions| checks for cross-domain cookies.
* |cookies.set| calls with an explicit |path| or |httpOnly| value.
* |cookies.set| calls without an explicit |name|, |value|, or |expirationDate|.
* |cookies.set| calls for session cookies.
* Cookie eviction events for expired cookies.


https://people.mozilla.org/~kmaglione/webextension-test-coverage/toolkit/components/extensions/ext-cookies.js.html

Updated

2 years ago
Flags: blocking-webextensions?
Priority: -- → P3
Whiteboard: [test] triaged

Updated

2 years ago
Flags: blocking-webextensions? → blocking-webextensions+
(Assignee)

Updated

2 years ago
Assignee: nobody → bob.silverberg
Status: NEW → ASSIGNED
Iteration: --- → 48.1 - Mar 21
(Assignee)

Updated

2 years ago
Depends on: 1255569
(Assignee)

Comment 1

2 years ago
Created attachment 8729169 [details]
MozReview Request: Bug 1236118 - Complete test coverage for the WebExtension cookies API, r?kmag

Add coverage for:
* checkSetCookiePermissions for invalid scheme and failing checks for cross-domain cookies.
* |query| - Selecting an enumerator for queries with no |url| or |domain| filter.
* |query| - Matching and non-matching cookies for the |domain|, |path|, |secure|, |session|, and |storeId| filters.
* |query| - Non-matching cookies for the domain and path portions of the |url| filter.
* |cookies.set| calls with an explicit |path| or |httpOnly| value.
* |cookies.set| calls without an explicit |name|, |value|, or |expirationDate|.

Review commit: https://reviewboard.mozilla.org/r/39273/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39273/
Attachment #8729169 - Flags: review?(kmaglione+bmo)
Attachment #8729169 - Flags: review?(kmaglione+bmo) → review+
Comment on attachment 8729169 [details]
MozReview Request: Bug 1236118 - Complete test coverage for the WebExtension cookies API, r?kmag

https://reviewboard.mozilla.org/r/39273/#review36057
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/93f0785edcc7
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.