1236118 - Complete test coverage for the WebExtension cookies API.

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect, P3)

Description

[Kris Maglione [:kmag]]

There's a lot of missing coverage in the |query| function, in particular:

* Selecting an enumerator for queries with no |url| or |domain| filter.
* Matching and non-matching cookies for the |domain|, |path|, |secure|, |session|, and |storeId| filters.
* Non-matching cookies for the domain and path portions of the |url| filter.
* Failing |checkSetCookiePermissions| checks for cross-domain cookies.
* |cookies.set| calls with an explicit |path| or |httpOnly| value.
* |cookies.set| calls without an explicit |name|, |value|, or |expirationDate|.
* |cookies.set| calls for session cookies.
* Cookie eviction events for expired cookies.


https://people.mozilla.org/~kmaglione/webextension-test-coverage/toolkit/components/extensions/ext-cookies.js.html

Comment 1

[Bob Silverberg [:bsilverberg]]

Attachment: MozReview Request: Bug 1236118 - Complete test coverage for the WebExtension cookies API, r?kmag

Add coverage for:
* checkSetCookiePermissions for invalid scheme and failing checks for cross-domain cookies.
* |query| - Selecting an enumerator for queries with no |url| or |domain| filter.
* |query| - Matching and non-matching cookies for the |domain|, |path|, |secure|, |session|, and |storeId| filters.
* |query| - Non-matching cookies for the domain and path portions of the |url| filter.
* |cookies.set| calls with an explicit |path| or |httpOnly| value.
* |cookies.set| calls without an explicit |name|, |value|, or |expirationDate|.

Review commit: https://reviewboard.mozilla.org/r/39273/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39273/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8729169 [details]
MozReview Request: Bug 1236118 - Complete test coverage for the WebExtension cookies API, r?kmag

https://reviewboard.mozilla.org/r/39273/#review36057

Comment 3

[Bob Silverberg [:bsilverberg]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=daea8b51f3aa

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/93f0785edcc7

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/93f0785edcc7