Closed Bug 1236232 Opened 4 years ago Closed 4 years ago

crash in java.lang.NullPointerException: at android.support.design.widget.Snackbar.<init>(Unknown Source)

Categories

(Firefox for Android :: Web Apps (PWAs), defect, critical)

45 Branch
Unspecified
Android
defect
Not set
critical

Tracking

()

RESOLVED FIXED
Firefox 46
Tracking Status
firefox45 --- fixed
firefox46 --- fixed
fennec 45+ ---

People

(Reporter: kats, Assigned: sebastian)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-37b4cd90-bf6c-4da6-84cd-a59942160102.
=============================================================

Install a webapp using aurora. Open it, long-press on a link, and select copy link. I haven't tried reproducing it yet.
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
tracking-fennec: --- → ?
(In reply to Sebastian Kaspari (:sebastian) from comment #2)
> Created attachment 8705726 [details]
> MozReview Request: Bug 1236232 - Only use root layout as snackbar parent if
> it exists (Webapps). r?mcomella
> 
> Review commit: https://reviewboard.mozilla.org/r/30173/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/30173/

This patch is built on top of the changes in bug 1234295.
Comment on attachment 8705726 [details]
MozReview Request: Bug 1236232 - Only use root layout as snackbar parent if it exists (Webapps). r=mcomella

https://reviewboard.mozilla.org/r/30173/#review27187

::: mobile/android/base/java/org/mozilla/gecko/SnackbarHelper.java:135
(Diff revision 1)
> -            return activity.findViewById(R.id.root_layout);
> +            View view = activity.findViewById(R.id.root_layout);

nit: `final`
Attachment #8705726 - Flags: review?(michael.l.comella) → review+
Attachment #8705726 - Attachment description: MozReview Request: Bug 1236232 - Only use root layout as snackbar parent if it exists (Webapps). r?mcomella → MozReview Request: Bug 1236232 - Only use root layout as snackbar parent if it exists (Webapps). r=mcomella
Comment on attachment 8705726 [details]
MozReview Request: Bug 1236232 - Only use root layout as snackbar parent if it exists (Webapps). r=mcomella

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/30173/diff/1-2/
https://hg.mozilla.org/integration/fx-team/rev/92e6520552764d4fdd9e0b77d28ccef7179311be
Bug 1236232 - Only use root layout as snackbar parent if it exists (Webapps). r=mcomella
Comment on attachment 8705726 [details]
MozReview Request: Bug 1236232 - Only use root layout as snackbar parent if it exists (Webapps). r=mcomella

(Note: This patch is build on top of the patches in bug 1234295. I requested uplift for those patches too.)

Approval Request Comment

[Feature/regressing bug #]: Snackbars have been introduced app-wide in Firefox 45 - see meta bug 1157526.

[User impact if declined]: Whenever we show a snackbar in a webapp the app might crash.

[Describe test coverage new/current, TreeHerder]: Local testing and try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3b88a6cf94a

[Risks and why]: Low risk: Very minimal patch.

[String/UUID change made/needed]: -
Attachment #8705726 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/92e652055276
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment on attachment 8705726 [details]
MozReview Request: Bug 1236232 - Only use root layout as snackbar parent if it exists (Webapps). r=mcomella

Taking in 45. Thanks
Attachment #8705726 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
tracking-fennec: ? → 45+
You need to log in before you can comment on or make changes to this bug.