1236232 - crash in java.lang.NullPointerException: at android.support.design.widget.Snackbar.<init>(Unknown Source)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect)

Description

[Kartikaya Gupta (email:[e-mail])]

This bug was filed from the Socorro interface and is 
report bp-37b4cd90-bf6c-4da6-84cd-a59942160102.
=============================================================

Install a webapp using aurora. Open it, long-press on a link, and select copy link. I haven't tried reproducing it yet.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Seems reproducible, here is another one: https://crash-stats.mozilla.com/report/index/bp-c0f2d1eb-5011-48e0-aeae-8a9c92160102

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1236232 - Only use root layout as snackbar parent if it exists (Webapps). r=mcomella

Review commit: https://reviewboard.mozilla.org/r/30173/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30173/

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Sebastian Kaspari (:sebastian) from comment #2)
> Created attachment 8705726 [details]
> MozReview Request: Bug 1236232 - Only use root layout as snackbar parent if
> it exists (Webapps). r?mcomella
> 
> Review commit: https://reviewboard.mozilla.org/r/30173/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/30173/

This patch is built on top of the changes in bug 1234295.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8705726 [details]
MozReview Request: Bug 1236232 - Only use root layout as snackbar parent if it exists (Webapps). r=mcomella

https://reviewboard.mozilla.org/r/30173/#review27187

::: mobile/android/base/java/org/mozilla/gecko/SnackbarHelper.java:135
(Diff revision 1)
> -            return activity.findViewById(R.id.root_layout);
> +            View view = activity.findViewById(R.id.root_layout);

nit: `final`

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8705726 [details]
MozReview Request: Bug 1236232 - Only use root layout as snackbar parent if it exists (Webapps). r=mcomella

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/30173/diff/1-2/

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3b88a6cf94a

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/92e6520552764d4fdd9e0b77d28ccef7179311be
Bug 1236232 - Only use root layout as snackbar parent if it exists (Webapps). r=mcomella

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8705726 [details]
MozReview Request: Bug 1236232 - Only use root layout as snackbar parent if it exists (Webapps). r=mcomella

(Note: This patch is build on top of the patches in bug 1234295. I requested uplift for those patches too.)

Approval Request Comment

[Feature/regressing bug #]: Snackbars have been introduced app-wide in Firefox 45 - see meta bug 1157526.

[User impact if declined]: Whenever we show a snackbar in a webapp the app might crash.

[Describe test coverage new/current, TreeHerder]: Local testing and try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3b88a6cf94a

[Risks and why]: Low risk: Very minimal patch.

[String/UUID change made/needed]: -

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/92e652055276

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8705726 [details]
MozReview Request: Bug 1236232 - Only use root layout as snackbar parent if it exists (Webapps). r=mcomella

Taking in 45. Thanks

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b32e085b9f62