Closed
Bug 1236325
Opened 8 years ago
Closed 8 years ago
Annotate intentional switch fallthrough to suppress -Wimplicit-fallthrough warning in satchel
Categories
(Toolkit :: Autocomplete, defect)
Toolkit
Autocomplete
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
|
1.22 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
clang's -Wimplicit-fallthrough warnings (not yet enabled in mozilla-central) warn about switch cases that fall through without a break or return statement. MOZ_FALLTHROUGH (bug 1215411) is an annotation to suppress -Wimplicit-fallthrough warnings about switch cases that intentionally fall through without a break or return statement. MOZ_FALLTHROUGH is only needed on cases that have code. toolkit/components/satchel/nsFormFillController.cpp:974:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
Attachment #8703401 -
Flags: review?(mak77)
|
||
Updated•8 years ago
|
Attachment #8703401 -
Flags: review?(mak77) → review+
|
||
Comment 2•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5a26df67b3fd
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•