1236334 - server_test: should return != 0 in case of error

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P2)

Description

[Guido Günther]

Attachment: 0002-Correctly-return-exit-status-on-failure.patch

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0 Iceweasel/38.5.0
Build ID: 20151216011944

Steps to reproduce:

Run ./server_test with address already in use


Actual results:

Test printed "FAIL" but exit status was 0.


Expected results:

Test should fail with exit status != 0 like the other tests. Patch attached.

Comment 1

[Wan-Teh Chang]

Comment on attachment 8703413 [details] [diff] [review]
0002-Correctly-return-exit-status-on-failure.patch

Review of attachment 8703413 [details] [diff] [review]:
-----------------------------------------------------------------

Guido: thanks a lot for the patch. I suggest two small changes.

::: nspr/pr/tests/server_test.c
@@ +91,4 @@
>  			break;
>  		case FAIL:
>  			printf ("FAIL\n");
> +			failed_already=FAIL;

Please set failed_already to 1, for consistency with existing code
in other tests.

Also add spaces around the equal sign =:

    failed_already = 1;

Note: there are many other places where we should set failed_already
to 1, but you don't need to fix them exhaustively in this patch.

Comment 2

[Guido Günther]

Attachment: 0001-Bug-1236334-Correctly-return-exit-status-on-failure.patch

Comments addressed. Thanks for the review.

Comment 3

[Wan-Teh Chang]

Comment on attachment 8704662 [details] [diff] [review]
0001-Bug-1236334-Correctly-return-exit-status-on-failure.patch

r=wtc. Thanks.
https://hg.mozilla.org/projects/nspr/rev/ca7ec69693dd