1236343 - Allow Windows dump_syms to work with unregistered msdiaNNN.dll

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Biru [:poiru]]

For VS2015, we will *not* install VS2015 onto the builders. Instead, we will use tooltool to download a packaged VS install like we do with clang. dump_syms does not like this because its `CoCreateInstance(CLSID_DiaSource)` relies on msdia140.dll being registered on the system.

The DIA SDK includes a helpful NoRegCoCreate function that allows one to load and use msdia140.dll as long as its in the path. We should use it.

Comment 1

[Biru [:poiru]]

Attachment: Try loading msdiaNNN.dll if CoCreateInstance(CLSID_DiaSource) fails

Because tools/windows/symupload/symupload.cc uses `nullptr` (which
requires VS2010), the CLSID comparison is only performed for msdia100.dll
and later. When compiling with an older (or future) CLSID_DiaSource, we
retain the existing behaviour (i.e. fail if CoCreateInstance fails).

---

ted, this is a patch for Breakpad master. Can you review and land it for me? I can adjust and land the patch for mozilla-central after that.

Comment 2

[(not currently active) Ted Mielczarek]

I think we require VC2013 or newer to build Breakpad now, but I'm not 100% sure. Can you upload this patch to 
http://codereview.chromium.org/ ? The Google folks don't like it when I review patches in Bugzilla. :-/

Comment 3

[Biru [:poiru]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> I think we require VC2013 or newer to build Breakpad now, but I'm not 100%
> sure. Can you upload this patch to 
> http://codereview.chromium.org/ ? The Google folks don't like it when I
> review patches in Bugzilla. :-/

Done: https://codereview.chromium.org/1601513002

Comment 4

[(not currently active) Ted Mielczarek]

Landed upstream:
https://chromium.googlesource.com/breakpad/breakpad/+/1e24e66fbbc8855b93932988769c5267c265fc8d

Feel free to cherry-pick this into mozilla-central.

Comment 5

[Biru [:poiru]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/16f3d1ce559a0c9efe5068ae8fc7a84e959b52e5
Bug 1236343 - Cherry-pick upstream Breakpad commit "Try loading msdiaNNN.dll if CoCreateInstance(CLSID_DiaSource) fails". r=ted

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/16f3d1ce559a