Closed
Bug 1236373
Opened 8 years ago
Closed 8 years ago
JSCLASS_CACHED_PROTO_WIDTH is in the js namespace
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla46
People
(Reporter: leper, Assigned: leper)
Details
Attachments
(1 file)
1.62 KB,
patch
|
Waldo
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-esr38+
|
Details | Diff | Splinter Review |
Since b0eda4f5c21e users of JSCLASS_CACHED_PROTO_KEY (via JSCLASS_CACHED_PROTO_MASK) outside of the js namespace are broken.
It would be nice to have this in a release of SpiderMonkey 38, not sure if I should add anything for that.
Attachment #8703455 -
Flags: review?(jwalden+bmo)
Updated•8 years ago
|
Attachment #8703455 -
Flags: review?(jwalden+bmo) → review+
Comment 3•8 years ago
|
||
Comment on attachment 8703455 [details] [diff] [review] Add the namespace to the macro usage Approval Request Comment [Feature/regressing bug #]: N/A [User impact if declined]: Slightly more work for embedders to use the 38/45 branches. (We expect to spin a fresh SpiderMonkey release from 45, hence the request there. No releasing is planned for 39-44, hence no requests for beta or any other branches.) [Describe test coverage new/current, TreeHerder]: N/A [Risks and why]: Entirely risk-free. A very, very obviously correct C++ change accounting for C++ scoping rules. (Gecko doesn't need this because it's not a very *good* JSAPI user and cheats like crazy.) [String/UUID change made/needed]: N/A
Attachment #8703455 -
Flags: approval-mozilla-esr38?
Attachment #8703455 -
Flags: approval-mozilla-aurora?
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7ecb29ab42b7
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Updated•8 years ago
|
status-firefox45:
--- → affected
status-firefox-esr38:
--- → affected
Updated•8 years ago
|
Assignee: nobody → leper
Comment 5•8 years ago
|
||
Comment on attachment 8703455 [details] [diff] [review] Add the namespace to the macro usage Jeff, Why do you think we should take it in ESR? Thanks Taking it in aurora.
Flags: needinfo?(jwalden+bmo)
Attachment #8703455 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 6•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/bfcf642c55e4
Comment 7•8 years ago
|
||
Sorry -- "We expect to spin a fresh SpiderMonkey release from 45, hence the request there" also applies to 38, the current stable version we support in advance of 45 going to release. That is, right now people embedding stable SpiderMonkey should be embedding 38 -- so we want this fixed there for their sakes.
Flags: needinfo?(jwalden+bmo)
Comment 8•8 years ago
|
||
Just looking to see how we usually handle SpiderMonkey. From https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey, is the standalone SpiderMonkey something we build separately from 38esr?
Flags: needinfo?(jwalden+bmo)
Comment 9•8 years ago
|
||
Comment on attachment 8703455 [details] [diff] [review] Add the namespace to the macro usage If this makes your life easier, why not
Attachment #8703455 -
Flags: approval-mozilla-esr38? → approval-mozilla-esr38+
Comment 11•8 years ago
|
||
Standalone SpiderMonkey has a separate release process, yes. But I believe it does use the ESR branch directly.
Flags: needinfo?(jwalden+bmo)
You need to log in
before you can comment on or make changes to this bug.
Description
•