1236389 - Annotate intentional switch fallthroughs to suppress -Wimplicit-fallthrough warnings in mozapps/update

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: updater_MOZ_FALLTHROUGH.patch

clang's -Wimplicit-fallthrough warnings (not yet enabled in mozilla-central) warn about switch cases that fall through without a break or return statement. MOZ_FALLTHROUGH (bug 1215411) is an annotation to suppress -Wimplicit-fallthrough warnings about switch cases that intentionally fall through without a break or return statement.  MOZ_FALLTHROUGH is only needed on cases that have code.

toolkit/mozapps/update/updater/updater.cpp:3722:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels

toolkit/mozapps/update/updater/updater.cpp:3768:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels

Comment 1

[Brian R. Bondy [:bbondy]]

rstrong would be a better reviewer for this. 

I tried to change myself but I'm getting:

> away until 1/4 Robert Strong [:rstrong] (use needinfo to contact me) <[e-mail]> is not currently accepting 'review' requests.

Please try to change it to him tomorrow.

Comment 2

[Brian R. Bondy [:bbondy]]

Comment on attachment 8703471 [details] [diff] [review]
updater_MOZ_FALLTHROUGH.patch

Review of attachment 8703471 [details] [diff] [review]:
-----------------------------------------------------------------

Moving to rstrong

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9ebd5dfc4190

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9ebd5dfc4190