1236390 - Suppress -Wimplicit-fallthrough warnings in third-party code from Google Breakpad

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: crashreporter_Wno-implicit-fallthrough.patch

clang's -Wimplicit-fallthrough warnings (not yet enabled in mozilla-central) warn about switch cases that fall through without a break or return statement. MOZ_FALLTHROUGH (bug 1215411) is an annotation to suppress -Wimplicit-fallthrough warnings where the fallthrough is intentional.

However, these crashreporter warnings are in third-party Breakpad code so we must suppress the warnings (or `ALLOW_COMPILER_WARNINGS = True` the crashreporter code) instead of annotating the fallthroughs:

toolkit/crashreporter/google-breakpad/src/common/dwarf/dwarf2reader.cc:195:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels

toolkit/crashreporter/google-breakpad/src/processor/minidump.cc:4022:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels

Comment 1

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/406857df1c2e

Comment 2

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/406857df1c2e