1236399 - [TV][2.5] Character limits of app's name in preview area

Status: RESOLVED FIXED

(Marketplace Graveyard :: General, defect, P2)

Description

[Joseph Yeh [:joseph]]

If app's name is too long, it will get cut off due to the character limits.

Comment 1

[Joseph Yeh [:joseph]]

Solutions will be as follows:

Preview Area
1. Adding the width of text about 150px. Helen will help to define the visual spec.
2. If the title still exceed the width limit, use text carousal when user stop on the item for more than 3 seconds.

App Name
1. If the title exceed the width limit, just use the name on the icon.

Comment 2

[Joseph Yeh [:joseph]]

Hi Helen, can you provide the updated visual spec? Thanks!

Comment 3

[Helen Huang [:HHuang]]

Hi Joseph, the width of text areas have been modified and updated to the visual spec. Link: http://bit.ly/1lr4WNu

Let me know if any questions, thanks!

Comment 4

[Joseph Yeh [:joseph]]

Attachment: jostw:josyeh/Marketplace/master/Bug1236399 > mozilla-b2g:master

Hi Davor, this patch adds a text carousel to the app's name in the preview area when the name is too long. You can see more details in this bug.

And I also fix the problem that the app's name on the app icon will hit the border which you had mentioned before.

The visual effect and the animation had reviewed by Helen and Tori.

If the app name is too short that you are unable to see the carousel, you can double or triple the app name in app_preview.html in order to see the animation.

Please let me know if any questions, thanks :)

Comment 5

[Davor Spasovski [:spasovski]]

The code itself looks good (though some more code comments might be useful) and I'll trust the existing visual review - which saves us both time.

Comment 6

[Joseph Yeh [:joseph]]

OK, I'll add some code comments before I merge them. Thanks!

Comment 7

[Joseph Yeh [:joseph]]

Landed in marketplace-tv-front-end master.

https://github.com/mozilla-b2g/marketplace-tv-front-end/commit/a61459c62f7caa44d91f7ec4e8261601bc271684