Closed Bug 1236399 Opened 7 years ago Closed 7 years ago
.5] Character limits of app's name in preview area
63 bytes, text/x-github-pull-request
|Details | Review|
If app's name is too long, it will get cut off due to the character limits.
Solutions will be as follows: Preview Area 1. Adding the width of text about 150px. Helen will help to define the visual spec. 2. If the title still exceed the width limit, use text carousal when user stop on the item for more than 3 seconds. App Name 1. If the title exceed the width limit, just use the name on the icon.
Hi Helen, can you provide the updated visual spec? Thanks!
Hi Joseph, the width of text areas have been modified and updated to the visual spec. Link: http://bit.ly/1lr4WNu Let me know if any questions, thanks!
Hi Davor, this patch adds a text carousel to the app's name in the preview area when the name is too long. You can see more details in this bug. And I also fix the problem that the app's name on the app icon will hit the border which you had mentioned before. The visual effect and the animation had reviewed by Helen and Tori. If the app name is too short that you are unable to see the carousel, you can double or triple the app name in app_preview.html in order to see the animation. Please let me know if any questions, thanks :)
Attachment #8704694 - Flags: review?(dspasovski)
The code itself looks good (though some more code comments might be useful) and I'll trust the existing visual review - which saves us both time.
Attachment #8704694 - Flags: review?(dspasovski) → review+
OK, I'll add some code comments before I merge them. Thanks!
Landed in marketplace-tv-front-end master. https://github.com/mozilla-b2g/marketplace-tv-front-end/commit/a61459c62f7caa44d91f7ec4e8261601bc271684
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.