1236577 - turn off -Wignored-attributes when compiling with clang-cl

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nathan Froyd [:froydnj]]

Several JS engine header files, notable RootingAPI.h, do:

class JS_PUBLIC_API(...) { ... };

which sticks __declspec(dllimport) on the type.  clang-cl warns us that
it doesn't implement that, but since we're compiling with clang-cl as an
interesting side project, rather than shipping releases with it, we can
ignore that warning.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: turn off -Wignored-attributes when compiling with clang-cl

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8703679 [details] [diff] [review]
turn off -Wignored-attributes when compiling with clang-cl

Review of attachment 8703679 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +2278,5 @@
> +            # Several JS engine header files use __declspec(dllexport) on
> +            # classes, and clang-cl helpfully warns about its non-support
> +            # for such cases.  We're not particularly worried about that,
> +            # so ignore that warning.
> +            CXXFLAGS="$CXXFLAGS -Wno-ignored-attributes"

Why not change the macros to not expand to __declspec(dllexport)?

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a174c2f65f62

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a174c2f65f62