Closed Bug 1236577 Opened 9 years ago Closed 9 years ago

turn off -Wignored-attributes when compiling with clang-cl

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox46 fixed)

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 file)

Several JS engine header files, notable RootingAPI.h, do: class JS_PUBLIC_API(...) { ... }; which sticks __declspec(dllimport) on the type. clang-cl warns us that it doesn't implement that, but since we're compiling with clang-cl as an interesting side project, rather than shipping releases with it, we can ignore that warning.
Blocks: winclang, 1042132
Comment on attachment 8703679 [details] [diff] [review] turn off -Wignored-attributes when compiling with clang-cl Review of attachment 8703679 [details] [diff] [review]: ----------------------------------------------------------------- ::: configure.in @@ +2278,5 @@ > + # Several JS engine header files use __declspec(dllexport) on > + # classes, and clang-cl helpfully warns about its non-support > + # for such cases. We're not particularly worried about that, > + # so ignore that warning. > + CXXFLAGS="$CXXFLAGS -Wno-ignored-attributes" Why not change the macros to not expand to __declspec(dllexport)?
Attachment #8703679 - Flags: review?(mh+mozilla) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: