1236616 - Enable "browser.tabs.useCache" by default

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

This feature landed behind a Nightly-only flag.

This sounds like a good time to use switchboard to release this in a staged rollout and listen for bug reports.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: enable-offline-cache v0.1

Comment 2

[:Margaret Leibovic]

Comment on attachment 8709096 [details] [diff] [review]
enable-offline-cache v0.1

Review of attachment 8709096 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/app/mobile.js
@@ -32,5 @@
>  pref("browser.tabs.expireTime", 900);
>  
>  // Control whether tab content should try to load from disk cache when network
>  // is offline.
> -#ifdef NIGHTLY_BUILD

Or, if you're a huge advocate for switchboard and staged rollouts, you could put this behind a switchboard control.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/8415015a072f

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to :Margaret Leibovic from comment #2)

> Or, if you're a huge advocate for switchboard and staged rollouts, you could
> put this behind a switchboard control.

This is a good idea, but we don't have a pattern for using SwitchBoard from JS or for handling prefs yet. I didn't want to rush a pattern in with this bug, but we could followup.

Comment 5

[:Margaret Leibovic]

(In reply to Mark Finkle (:mfinkle) from comment #4)
> (In reply to :Margaret Leibovic from comment #2)
> 
> > Or, if you're a huge advocate for switchboard and staged rollouts, you could
> > put this behind a switchboard control.
> 
> This is a good idea, but we don't have a pattern for using SwitchBoard from
> JS or for handling prefs yet. I didn't want to rush a pattern in with this
> bug, but we could followup.

Someone needs to be the first person to come up with the pattern!

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8415015a072f