Closed Bug 1236616 Opened 5 years ago Closed 5 years ago

Enable "browser.tabs.useCache" by default

Categories

(Firefox for Android :: General, defect)

35 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- fixed
fennec 46+ ---

People

(Reporter: Margaret, Assigned: mfinkle)

References

Details

Attachments

(1 file)

This feature landed behind a Nightly-only flag.

This sounds like a good time to use switchboard to release this in a staged rollout and listen for bug reports.
tracking-fennec: ? → Nightly+
Depends on: 1236130
Assignee: nobody → mark.finkle
Attachment #8709096 - Flags: review?(margaret.leibovic)
Comment on attachment 8709096 [details] [diff] [review]
enable-offline-cache v0.1

Review of attachment 8709096 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/app/mobile.js
@@ -32,5 @@
>  pref("browser.tabs.expireTime", 900);
>  
>  // Control whether tab content should try to load from disk cache when network
>  // is offline.
> -#ifdef NIGHTLY_BUILD

Or, if you're a huge advocate for switchboard and staged rollouts, you could put this behind a switchboard control.
Attachment #8709096 - Flags: review?(margaret.leibovic) → review+
(In reply to :Margaret Leibovic from comment #2)

> Or, if you're a huge advocate for switchboard and staged rollouts, you could
> put this behind a switchboard control.

This is a good idea, but we don't have a pattern for using SwitchBoard from JS or for handling prefs yet. I didn't want to rush a pattern in with this bug, but we could followup.
(In reply to Mark Finkle (:mfinkle) from comment #4)
> (In reply to :Margaret Leibovic from comment #2)
> 
> > Or, if you're a huge advocate for switchboard and staged rollouts, you could
> > put this behind a switchboard control.
> 
> This is a good idea, but we don't have a pattern for using SwitchBoard from
> JS or for handling prefs yet. I didn't want to rush a pattern in with this
> bug, but we could followup.

Someone needs to be the first person to come up with the pattern!
https://hg.mozilla.org/mozilla-central/rev/8415015a072f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
tracking-fennec: Nightly+ → 46+
Depends on: 1258428
You need to log in before you can comment on or make changes to this bug.