1236619 - jsmath.cpp:756:58: error: ignoring return value of ‘ssize_t read(int, void*, size_t)’

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

I'm getting a compiler error with warnings treated as failures:

  /srv/mozilla-central/js/src/jsmath.cpp:756:58: error: ignoring return value of ‘ssize_t read(int, void*, size_t)’,  declared with attribute warn_unused_result [-Werror=unused-result]

This needs a mozilla::Unused.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Fix compilation failure with warnings-as-errors with some compilers. r=jandem

Comment 2

[Chris Peterson [:cpeterson]]

I forgot about the warn_unused_result attribute on read() in (some versions of?) glibc's header files. We should really update our build machines' header files to this version.

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 8703745 [details] [diff] [review]
Fix compilation failure with warnings-as-errors with some compilers. r=jandem

Review of attachment 8703745 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing review.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2bc98e261d12

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2bc98e261d12