Closed
Bug 1236619
Opened 10 years ago
Closed 10 years ago
jsmath.cpp:756:58: error: ignoring return value of ‘ssize_t read(int, void*, size_t)’
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
Attachments
(1 file)
|
1.25 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
I'm getting a compiler error with warnings treated as failures:
/srv/mozilla-central/js/src/jsmath.cpp:756:58: error: ignoring return value of ‘ssize_t read(int, void*, size_t)’, declared with attribute warn_unused_result [-Werror=unused-result]
This needs a mozilla::Unused.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8703745 -
Flags: review?(jdemooij)
|
||
Comment 2•10 years ago
|
||
I forgot about the warn_unused_result attribute on read() in (some versions of?) glibc's header files. We should really update our build machines' header files to this version.
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8703745 [details] [diff] [review]
Fix compilation failure with warnings-as-errors with some compilers. r=jandem
Review of attachment 8703745 [details] [diff] [review]:
-----------------------------------------------------------------
Stealing review.
Attachment #8703745 -
Flags: review?(jdemooij) → review+
|
||
Comment 5•10 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•