1236621 - Create a central place for permissions manifest entries

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[:Margaret Leibovic]

While working on bug 1234629, I wanted to find a way to include our normal permissions manifest entries in the bouncer APK manifest.

nalexander mentioned wanting to create a central place to declare these permissions, which would make it simpler to include these in the bouncer manifest. Over to you for more details about what you have in mind...

Comment 1

[Nick Alexander :nalexander [he/him]]

(In reply to :Margaret Leibovic from comment #0)
> While working on bug 1234629, I wanted to find a way to include our normal
> permissions manifest entries in the bouncer APK manifest.
> 
> nalexander mentioned wanting to create a central place to declare these
> permissions, which would make it simpler to include these in the bouncer
> manifest. Over to you for more details about what you have in mind...

My PUT here is:

We already have a bunch of permissions XML snippets in the tree: https://dxr.mozilla.org/mozilla-central/search?tree=mozilla-central&q=path%3A*permissions*xml.in&redirect=true yields 4.  Let's follow suit and extract the core permissions into mobile/android/base/FennecManifest_permissions.xml.in.  Then let's #include that in m/a/b/AndroidManifest.xml.in; and include all the other permissions snippets as appropriate in mobile/android/bouncer/AndroidManifest.xml.in.  That's a reasonable way to centralize the permissions.

It's worth noting that this kind of sham permissions declaring doesn't get better with Gradle, since it's not a good idea to have a stub Gradle project only for permissions, since it's hard to make lint and other static analyzers work well with such configurations.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1236621 - Extract main APK permissions into included preamble. r?margaret

Short and sweet.

Review commit: https://reviewboard.mozilla.org/r/32705/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32705/

Comment 3

[:Margaret Leibovic]

Comment on attachment 8712933 [details]
MozReview Request: Bug 1236621 - Extract main APK permissions into included preamble. r?margaret

https://reviewboard.mozilla.org/r/32705/#review29561

Comment 4

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/fcac60741f1af3fb5f670d0154e3d9a987e1d515
Bug 1236621 - Extract main APK permissions into included preamble. r=margaret

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fcac60741f1a

Comment 6

[Nick Alexander :nalexander [he/him]]

remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/45a841d2c188

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/releases/mozilla-beta/rev/3120bbed5ff0 for android bustage

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

This just landed again in 46 so I'm marking it fixed. Hope it sticks this time!

Comment 9

[Nick Alexander :nalexander [he/him]]

(In reply to Wes Kocher (:KWierso) from comment #7)
> Backed out in https://hg.mozilla.org/releases/mozilla-beta/rev/3120bbed5ff0
> for android bustage

As :lizzard says, this relanded: https://hg.mozilla.org/releases/mozilla-beta/rev/ae9d8448101f