123666 - Touch-up for disabled Classic buttons

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[Greg Valure]

Minor improvements to the disabled Forward and Stop buttons in Classic.  The
bottom row of the disabled Forward button isn't hatched, and the hatching in the
disabled Stop button breaks pattern, causing banding.

The replacement images were made from the originals so they are the same size
and color depth, have the same palette, and the icons are positioned correctly
within them.  Only the absolute minimum required was changed.

2002-02-04-06 Win98 (0.9.8 milestone)

Comment 1

[Greg Valure]

Attachment: Fixed chrome://navigator/skin/icons/btn1.gif

Comment 2

[Greg Valure]

Attachment: Fixed chrome://communicator/skin/icons/btn1.gif

Comment 3

[Greg Valure]

Attachment: Shot of changes

Comment 4

[Bradley Baetz (:bbaetz)]

confirming for consideration

Comment 5

[andreww]

Comment on attachment 67997 [details]
Fixed chrome://navigator/skin/icons/btn1.gif

r=andreww  just make  sure that your changes dont change the pixel offsets of
the images so that the -moz-image-regions dont get off	track

Comment 6

[andreww]

Comment on attachment 67998 [details]
Fixed chrome://communicator/skin/icons/btn1.gif

r=andreww

Comment 7

[Greg Valure]

I worked from the originals and was careful about not changing anything else. 
They're okay in that respect.

Comment 8

[Joe Hewitt (gone)]

andrew, can you take this?

Comment 9

[andreww]

ok - though this may need a new reviewer now :)

Comment 10

[Greg Valure]

Your review should still be valid considering you didn't create the replacement
images.

Comment 11

[andreww]

hewitt - can you sr?

Comment 12

[Joe Hewitt (gone)]

sr=hewitt

Comment 13

[andreww]

ok greg are the gif's you posted here the ones you want me to check in, or 
do you want to attach a zip file with the gifs together?

Comment 14

[Greg Valure]

The two gifs attached can go in as is.

Comment 15

[Greg Valure]

Just curious, but why Mozilla 1.0?  Why can't this go in now?

Comment 16

[Joonas]

FYI: see also bug 125526 which wants to fix the weird gray stuff in the
navigation toolbar icons.

Comment 17

[andreww]

Ill try to check this in today.

Comment 18

[andreww]

Im guessing 125526 superceeds this one since  it incorporates this 
image's changes.  Will get that one checked in.

Comment 19

[Joonas]

andreww, please do check in the second gif from this bug 
(chrome://communicator/skin/icons/btn1.gif). It is not covered in bug 125526, I 
only stole (and tried to improve) the first gif from this bug.

Comment 20

[andreww]

yep - I understand. I'll check in the nav  one from the other bug and the 
communicator one from this bug. 

Comment 21

[andreww]

fix checked in.

Comment 22

[Patty Mac]

Verified (2002-02-21-08-trunk)