1236673 - Add a method for getting the canonical node along a path

Status: RESOLVED FIXED

(DevTools :: General, defect)

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Add a method for getting the canonical node along a path

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f05b7e96c7d9

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8703809 [details] [diff] [review]
Add a method for getting the canonical node along a path

Review of attachment 8703809 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/shared/heapsnapshot/DominatorTreeNode.js
@@ +266,5 @@
> + * @param {Array<NodeId>} path
> + *
> + * @returns {DominatorTreeNode|null}
> + */
> +DominatorTreeNode.getCanonicalNodeAlongPath = function (id, tree, path) {

This took me a bit to understand, but it seems pretty straight forward -- I'm not sure if `canonical` is the best word in this case -- we have concepts of an `id` as well as a `node`, and `path` in this method -- would something like `getNodeByIdFromPath`? Still a mouthful, but more immediately clear (IMO) what this is doing -- I don't feel too strongly about this though, this isn't a hot method used all over the place

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/8639f1a63095

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8639f1a63095

Comment 6

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected