1236738 - Requesting review from user with "Block review and feedback requests" enabled causes publish on push to fail spectacularly

Status: RESOLVED INVALID

(MozReview Graveyard :: General, defect)

Description

[Steven MacLeod [:smacleod]]

I requested review from glob while he was on PTO and using "Block review and feedback requests" in bugzilla. When I answered "yes" to auto publishing I got the following output back
> remote: ** Unknown exception encountered with possibly-broken third-party extension pushlog-feed
> remote: ** which supports versions unknown of Mercurial.
> remote: ** Please disable pushlog-feed and try your action again.
> remote: ** If that fixes the bug please report it to the extension author.
> remote: ** Python 2.7.10 (default, May 28 2015, 09:58:55) [GCC 4.4.7 20120313 (Red Hat 4.4.7-11)]
> remote: ** Mercurial Distributed SCM (version 3.6.2)
> remote: ** Extensions loaded: pushlog, pushlog-feed, buglink, serverlog, rbserver
> remote: Traceback (most recent call last):
> remote:   File "/repo/hg/venv_pash/bin/hg", line 43, in <module>
> remote:     mercurial.dispatch.run()
> remote:   File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/dispatch.py", line 54, in run
> remote:     sys.exit((dispatch(request(sys.argv[1:])) or 0) & 255)
> remote:   File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/dispatch.py", line 116, in dispatch
> remote:     ret = _runcatch(req)
> remote:   File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/dispatch.py", line 187, in _runcatch
> remote:     return _dispatch(req)
> remote:   File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/dispatch.py", line 920, in _dispatch
> remote:     cmdpats, cmdoptions)
> remote:   File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/dispatch.py", line 679, in runcommand
> remote:     ret = _runcommand(ui, options, cmd, d)
> remote:   File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/dispatch.py", line 1051, in _runcommand
> remote:     return checkargs()
> remote:   File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/dispatch.py", line 1011, in checkargs
> remote:     return cmdfunc()
> remote:   File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/dispatch.py", line 917, in <lambda>
> remote:     d = lambda: util.checksignature(func)(ui, *args, **cmdoptions)
> remote:   File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/util.py", line 801, in check
> remote:     return func(*args, **kwargs)
> remote:   File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/commands.py", line 5919, in serve
> remote:     s.serve_forever()
> remote:   File "/repo/hg/version-control-tools/hgext/serverlog/__init__.py", line 321, in serve_forever
> remote:     return super(sshserverwrapped, self).serve_forever()
> remote:   File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/sshserver.py", line 103, in serve_forever
> remote:     while self.serve_one():
> remote:   File "/repo/hg/version-control-tools/hgext/serverlog/__init__.py", line 350, in serve_one
> remote:     return super(sshserverwrapped, self).serve_one()
> remote:   File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/sshserver.py", line 121, in serve_one
> remote:     rsp = wireproto.dispatch(self.repo, self, cmd)
> remote:   File "/repo/hg/version-control-tools/hgext/serverlog/__init__.py", line 342, in dispatch
> remote:     return origdispatch(repo, proto, cmd)
> remote:   File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/wireproto.py", line 471, in dispatch
> remote:     return func(repo, proto, *args)
> remote:   File "/repo/hg/version-control-tools/hgext/reviewboard/hgrb/proto.py", line 500, in publishreviewseries
> remote:     lines.append('error %s %s' % (rrid, str(e)))
> remote: UnicodeEncodeError: 'ascii' codec can't encode character u'\u2039' in position 46: ordinal not in range(128)
> abort: unexpected response: empty string

Comment 2

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.