1236746 - Let FFmpeg manage its own memory allocation

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

The FFmpeg PDM override the FFmpeg default memory allocation to use our own. The API to override the memory allocation was deprecated several years ago.

Its unnecessary and when requesting to allocate YUV buffers on Windows XP and Windows 7 when using D3D9. We run out of buffers and causes memory allocation failures which lead to various gfx crashes (see bug 1236167).

Additionally, it's been the cause of various failures when we add new codecs as they all have particularities.
Also, not compatible with libavcodec 56 which has removed that deprecated API.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Let FFmpeg manages its own memory allocation.

Additionally, the API to override memory allocation has been deprecated years ago and it completely removed in libavcodec 57.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc4fd9433e21

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fc4fd9433e21

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8703920 [details] [diff] [review]
Let FFmpeg manages its own memory allocation.

Approval Request Comment
[Feature/regressing bug #]:1236746
[User impact if declined]: crashes when multiple file are opened like 1227723
[Describe test coverage new/current, TreeHerder]: In central for over a month
[Risks and why]: Low
[String/UUID change made/needed]: None

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8703920 [details] [diff] [review]
Let FFmpeg manages its own memory allocation.

Fix potential crashes, taking it.

Should be in 45 beta 2.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8bd83f9b5157