Closed Bug 1236786 Opened 4 years ago Closed 4 years ago

[WebGL2] pass getVertexAttrib in gl-object-get-calls.html

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: pchang, Unassigned)

References

Details

Attachments

(1 file)

test getVertexAttrib
PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_BUFFER_BINDING) is buffer
PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_ENABLED) is true
PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_SIZE) is 4
PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_STRIDE) is 0
PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_TYPE) is gl.FLOAT
PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_NORMALIZED) is false
PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_DIVISOR) is 0
FAIL gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_INTEGER) should be false (of type boolean). Was null (of type object).
PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_DIVISOR) is 2
PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_STRIDE) is 36
PASS gl.getVertexAttribOffset(1, gl.VERTEX_ATTRIB_ARRAY_POINTER) is 12
PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_ENABLED) is false
PASS gl.getVertexAttrib(1, gl.CURRENT_VERTEX_ATTRIB) is [5, 6, 7, 8]
PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_TYPE) is gl.INT
FAIL gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_INTEGER) should be true (of type boolean). Was null (of type object).
FAIL getError expected: NO_ERROR. Was INVALID_ENUM : 
PASS getVertexAttrib correctly handled invalid parameter enums
PASS getError was expected value: INVALID_VALUE : after evaluating: gl.getVertexAttrib(16, gl.CURRENT_VERTEX_ATTRIB)
Blocks: 1236394
Comment on attachment 8709851 [details]
MozReview Request: Bug 1236786 - [WebGL2] pass getVertexAttrib in gl-object-get-calls.html, r?jgilbert

https://reviewboard.mozilla.org/r/31583/#review28281

::: dom/canvas/WebGLContextVertices.cpp:363
(Diff revision 1)
> +        }

You need a break; at the end of this block.
Attachment #8709851 - Flags: review?(jgilbert)
Comment on attachment 8709851 [details]
MozReview Request: Bug 1236786 - [WebGL2] pass getVertexAttrib in gl-object-get-calls.html, r?jgilbert

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31583/diff/1-2/
Attachment #8709851 - Flags: review?(jgilbert)
Attachment #8709851 - Flags: review?(jgilbert) → review+
Comment on attachment 8709851 [details]
MozReview Request: Bug 1236786 - [WebGL2] pass getVertexAttrib in gl-object-get-calls.html, r?jgilbert

https://reviewboard.mozilla.org/r/31583/#review28449

::: dom/canvas/WebGLContextVertices.cpp:361
(Diff revision 2)
> +        if (IsWebGL2())
> +        {
> +            return JS::BooleanValue(mBoundVertexArray->mAttribs[index].integer);

if (IsWebGL2())
    return JS::...;

break;
Comment on attachment 8709851 [details]
MozReview Request: Bug 1236786 - [WebGL2] pass getVertexAttrib in gl-object-get-calls.html, r?jgilbert

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31583/diff/2-3/
https://hg.mozilla.org/mozilla-central/rev/1f7e085bf323
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.