Closed Bug 1236808 Opened 9 years ago Closed 9 years ago

[TV][2.5] Remove remote control apps from both engineering and production building lists on TV 2.5 branch

Categories

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:2.5+, b2g-v2.5 fixed, b2g-master wontfix)

Status:
RESOLVED FIXED
Milestone:
2.6 S5 - 1/15
Project Flags:
blocking-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-v2.5 --- fixed
b2g-master --- wontfix

People

(Reporter: lchang, Assigned: Fischer)

References

Details

(Whiteboard: [ft:conndevices][partner-cherry-pick][partner-blocker])

Attachments

(1 file)

[gaia] Fischer-L:moz-v2.5 > mozilla-b2g:v2.5
46 bytes, text/x-github-pull-request
lchang
: review+
jocheng
: approval-gaia-v2.5+
Details | Review
Since the Remote Control feature has been descoped on TV 2.5, let's remove the related apps from building lists.
[Blocking Requested - why for this release]: Feature has been descoped.
blocking-b2g: --- → 2.5?
blocking-b2g: 2.5? → 2.5+
status-b2g-v2.5: --- → affected
status-b2g-master: --- → affected
Whiteboard: [ft:conndevices][partner-cherry-pick][partner-blocker]
Priority: -- → P1
Target Milestone: --- → 2.6 S5 - 1/15
Hi Josh, I guess we should keep remote control apps in the master branch to continue developing it.
status-b2g-master: affected → wontfix
We found that the remote control apps have never existed in the TV 2.5 production build. (seems that they're added to TV master production build after 2.5 had been branched out.) Close this bug since it doesn't matter to have those apps in engineering build only.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Assignee: lchang → fliu
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Comment on attachment 8704958 [details] [review] [gaia] Fischer-L:moz-v2.5 > mozilla-b2g:v2.5 @Luke, Because the remote control is a v2.6 feature, this patch is to remove the remote control from the apps-engineering.list and the user pref about remote control from the custom-pref.js in the Gaia v2.5. Thanks
Attachment #8704958 - Flags: review?(lchang)
Comment on attachment 8704958 [details] [review] [gaia] Fischer-L:moz-v2.5 > mozilla-b2g:v2.5 Thanks for helping this.
Attachment #8704958 - Flags: review?(lchang) → review+
Land to v2.5: https://github.com/mozilla-b2g/gaia/commit/72bcc2dac977d2b916eaa78ec8d9caba2820dd74
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Hi Fischer, Please still raise 2.5 uplift request in the future. Thanks
Comment on attachment 8704958 [details] [review] [gaia] Fischer-L:moz-v2.5 > mozilla-b2g:v2.5 [Approval Request Comment] [Bug caused by] (feature/regressing bug #):1236808 [User impact] if declined:Would see remote control app which should no be in v2.5 [Testing completed]:Yes [Risk to taking this patch] (and alternatives if risky): Low [String changes made]: No
Attachment #8704958 - Flags: approval-gaia-v2.5?(jocheng)
Comment on attachment 8704958 [details] [review] [gaia] Fischer-L:moz-v2.5 > mozilla-b2g:v2.5 Approve for TV 2.5
Attachment #8704958 - Flags: approval-gaia-v2.5?(jocheng) → approval-gaia-v2.5+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: