Closed Bug 1236894 Opened 8 years ago Closed 8 years ago

Python client's _get_uri() URLs are missing the trailing slash

Categories

(Tree Management Graveyard :: Treeherder: Client Libraries, defect, P2)

Product:
Tree Management Graveyard
Component:
Treeherder: Client Libraries
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

[treeherder] mozilla:fix-client-api-urls > mozilla:master
47 bytes, text/x-github-pull-request
wlach
: review+
Details | Review 
In bug I spotted another use of a non-canonical URL:

127.0.0.1 - - [03/Jan/2016:16:41:58 -0800] "GET /api/optioncollectionhash HTTP/1.1" 301 - "-" "treeherder-pyclient/1.8.0"

This is from:
https://github.com/mozilla/treeherder/blob/a7bc7815e6cc198dbcdc73e269bb0634b1a19c08/treeherder/client/thclient/client.py#L719
https://github.com/mozilla/treeherder/blob/a7bc7815e6cc198dbcdc73e269bb0634b1a19c08/treeherder/client/thclient/client.py#L653
Attachment #8704139 - Flags: review?(wlachance)
Attachment #8704139 - Flags: review?(wlachance) → review+
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/86d01249c05818d9049efac3297cfd24a65c7a5f
Bug 1236894 - Add missing trailing slash to python client API URLs

To avoid 301 redirects during the request. This only affects client
functions that are not project-specific (the others use
`_get_project_uri()` instead).
Thank you for the review :-)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Blocks: 1236957
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: