Closed
Bug 1236894
Opened 9 years ago
Closed 9 years ago
Python client's _get_uri() URLs are missing the trailing slash
Categories
(Tree Management Graveyard :: Treeherder: Client Libraries, defect, P2)
Tree Management Graveyard
Treeherder: Client Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
In bug I spotted another use of a non-canonical URL:
127.0.0.1 - - [03/Jan/2016:16:41:58 -0800] "GET /api/optioncollectionhash HTTP/1.1" 301 - "-" "treeherder-pyclient/1.8.0"
This is from:
https://github.com/mozilla/treeherder/blob/a7bc7815e6cc198dbcdc73e269bb0634b1a19c08/treeherder/client/thclient/client.py#L719
https://github.com/mozilla/treeherder/blob/a7bc7815e6cc198dbcdc73e269bb0634b1a19c08/treeherder/client/thclient/client.py#L653
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Updated•9 years ago
|
Attachment #8704139 -
Flags: review?(wlachance)
|
||
Updated•9 years ago
|
Attachment #8704139 -
Flags: review?(wlachance) → review+
|
||
Comment 2•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/86d01249c05818d9049efac3297cfd24a65c7a5f
Bug 1236894 - Add missing trailing slash to python client API URLs
To avoid 301 redirects during the request. This only affects client
functions that are not project-specific (the others use
`_get_project_uri()` instead).
|
|
Assignee | |
Comment 3•9 years ago
|
||
Thank you for the review :-)
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•