1236926 - Remove the "you are now testing e10s" prompt

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Jim Mathies [:jimm]]

We should remove this, it's not really needed anymore on nightly/aurora and is causing a conflict with a11y (bug 1198459). e10s is stable enough that we no longer need to announce it's been turned on. We also don't want this showing up on beta or release.

Comment 1

[Gabor Krizsanits (INACTIVE)]

Stealing from Felipe...

Comment 2

[Gabor Krizsanits (INACTIVE)]

Attachment: rm showE10sActivatedNotice. v1

I still have to try this out somehow first, but filing the patch now because I was wondering if there is anything else that you think should be done here and I'm forgetting about.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8705738 [details] [diff] [review]
rm showE10sActivatedNotice. v1

Review of attachment 8705738 [details] [diff] [review]:
-----------------------------------------------------------------

You also need to remove the string from the localization files and the pref definition

Comment 4

[Gabor Krizsanits (INACTIVE)]

Attachment: rm showE10sActivatedNotice. v2

Thanks! About the localization, do I need to do anything else than removing it from the in tree en-US version like I do in this patch?

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8706291 [details] [diff] [review]
rm showE10sActivatedNotice. v2

Review of attachment 8706291 [details] [diff] [review]:
-----------------------------------------------------------------

nope, that's all!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b783a6da886

Comment 7

[Gabor Krizsanits (INACTIVE)]

Needinfo-ing myself to do aurora uplift once it's landed on mc.

Comment 8

[:Felipe Gomes (needinfo for replies!)]

Gabor: when you uplift to aurora, do not remove the strings from the browser.properties file. Just leave them there unused.  Changing these files outside of central causes problems to the l10n dashboards.

Comment 9

[Gabor Krizsanits (INACTIVE)]

(In reply to :Felipe Gomes (needinfo me!) from comment #8)
> Gabor: when you uplift to aurora, do not remove the strings from the
> browser.properties file. Just leave them there unused.  Changing these files
> outside of central causes problems to the l10n dashboards.

Thanks for the hint!

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8b783a6da886

Comment 11

[Gabor Krizsanits (INACTIVE)]

Attachment: rm showE10sActivatedNotice for aurora uplift

This version does not contain the localization string removals. This should be the one uplifted to aurora.

Comment 12

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8708950 [details] [diff] [review]
rm showE10sActivatedNotice for aurora uplift

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Per initial comment: "it's not really needed anymore on nightly/aurora and is causing a conflict with a11y (bug 1198459)"
[Describe test coverage new/current, TreeHerder]: It's on mc, but there is no automated test for it.
[Risks and why]: It just removes a warning prompt, should be safe.
[String/UUID change made/needed]: None in this version (original patch removes some localized strings, but this version does not have that change)

I carried over the review from Felipe from the patch that was landed on mc.

Comment 13

[Gabor Krizsanits (INACTIVE)]

Reopening for aurora uplift.

Comment 14

[Sylvestre Ledru [:Sylvestre]]

The bug doesn't have to be reopen for that. The uplift request is enough.

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/18163312de9c

Comment 16

[Khalid Syfullah Zaman [:khalid32]]

I have reproduced this bug on Nightly 46.0a1 (2016-01-05) on ubuntu 14.04 LTS, 32 bit!

The bug's fix is now verified on Latest Firefox Developer Edition 46.0a2!

Build ID: 20160205004003
User Agent: Mozilla/5.0 (X11; Linux i686; rv:46.0) Gecko/20100101 Firefox/46.0

Comment 17

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected