Closed Bug 1236926 Opened 4 years ago Closed 4 years ago

Remove the "you are now testing e10s" prompt

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 46
Tracking Status
e10s m8+ ---
firefox45 --- fixed
firefox46 --- fixed

People

(Reporter: jimm, Assigned: gkrizsanits)

Details

Attachments

(2 files, 1 obsolete file)

We should remove this, it's not really needed anymore on nightly/aurora and is causing a conflict with a11y (bug 1198459). e10s is stable enough that we no longer need to announce it's been turned on. We also don't want this showing up on beta or release.
Assignee: nobody → felipc
Stealing from Felipe...
Assignee: felipc → gkrizsanits
Attached patch rm showE10sActivatedNotice. v1 (obsolete) — Splinter Review
I still have to try this out somehow first, but filing the patch now because I was wondering if there is anything else that you think should be done here and I'm forgetting about.
Attachment #8705738 - Flags: review?(felipc)
Comment on attachment 8705738 [details] [diff] [review]
rm showE10sActivatedNotice. v1

Review of attachment 8705738 [details] [diff] [review]:
-----------------------------------------------------------------

You also need to remove the string from the localization files and the pref definition
Attachment #8705738 - Flags: review?(felipc) → feedback+
Thanks! About the localization, do I need to do anything else than removing it from the in tree en-US version like I do in this patch?
Attachment #8705738 - Attachment is obsolete: true
Attachment #8706291 - Flags: review?(felipc)
Comment on attachment 8706291 [details] [diff] [review]
rm showE10sActivatedNotice. v2

Review of attachment 8706291 [details] [diff] [review]:
-----------------------------------------------------------------

nope, that's all!
Attachment #8706291 - Flags: review?(felipc) → review+
Needinfo-ing myself to do aurora uplift once it's landed on mc.
Flags: needinfo?(gkrizsanits)
Gabor: when you uplift to aurora, do not remove the strings from the browser.properties file. Just leave them there unused.  Changing these files outside of central causes problems to the l10n dashboards.
(In reply to :Felipe Gomes (needinfo me!) from comment #8)
> Gabor: when you uplift to aurora, do not remove the strings from the
> browser.properties file. Just leave them there unused.  Changing these files
> outside of central causes problems to the l10n dashboards.

Thanks for the hint!
Flags: needinfo?(gkrizsanits)
https://hg.mozilla.org/mozilla-central/rev/8b783a6da886
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
This version does not contain the localization string removals. This should be the one uplifted to aurora.
Attachment #8708950 - Flags: review+
Comment on attachment 8708950 [details] [diff] [review]
rm showE10sActivatedNotice for aurora uplift

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Per initial comment: "it's not really needed anymore on nightly/aurora and is causing a conflict with a11y (bug 1198459)"
[Describe test coverage new/current, TreeHerder]: It's on mc, but there is no automated test for it.
[Risks and why]: It just removes a warning prompt, should be safe.
[String/UUID change made/needed]: None in this version (original patch removes some localized strings, but this version does not have that change)

I carried over the review from Felipe from the patch that was landed on mc.
Attachment #8708950 - Flags: approval-mozilla-aurora?
Reopening for aurora uplift.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
The bug doesn't have to be reopen for that. The uplift request is enough.
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Attachment #8708950 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I have reproduced this bug on Nightly 46.0a1 (2016-01-05) on ubuntu 14.04 LTS, 32 bit!

The bug's fix is now verified on Latest Firefox Developer Edition 46.0a2!

Build ID: 20160205004003
User Agent: Mozilla/5.0 (X11; Linux i686; rv:46.0) Gecko/20100101 Firefox/46.0
QA Whiteboard: [testday-20160205]
[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected
You need to log in before you can comment on or make changes to this bug.