1237041 - After crash pinned tabs are restored, but non-pinned tabs are not. See about:home, with the option restore tabs from a previous session.

Status: NEW

(Firefox :: Session Restore, defect)

Description

[Andrew McCreight [:mccr8]]

In preferences, under general, I have "Show my windows and tabs from last time"  selected for "When Nightly starts". If I quit the browser and restart it, then it restores all tabs as expected. However, if the browser crashes, then it restores pinned tabs, as expected, but it does not restore any non-pinned tabs. Instead, it sounds about:home, with the option to click to restore tabs from a previous session. If I click on that button, then it does restore the tabs as expected, so it isn't like the data is being lost.

I can reproduce this issue by killing Nightly process in Activity Monitor.

Comment 1

[Andrew McCreight [:mccr8]]

> Instead, it sounds about:home
This should be "it load about:home"

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Andrew, any chance that you can test if bug 1177310 is the regressor?

Comment 3

[Andrew McCreight [:mccr8]]

(In reply to Bill McCloskey (:billm) from comment #2)
> Andrew, any chance that you can test if bug 1177310 is the regressor?

I'll try that. Unfortunately I'm having some trouble getting mozregression to work with a profile, but I can try manually downloading builds.

I wasn't able to reproduce this issue in a couple of other profiles I tried besides my main profile. I'm not sure what the difference is.

Comment 4

[Andrew McCreight [:mccr8]]

I can reproduce this in my main profile as far back as 11-03, so maybe my profile is just in a messed up state. I noticed that even after I repeatedly kill the process I never get the "Oops, you keep crashing!" message where it shows a list of things to restore from a previous session, which I do see in other profiles.

Comment 5

[Wayne Mery (:wsmwk)]

Andrew, does this still happen for you when using a more current version?

Comment 6

[Andrew McCreight [:mccr8]]

(In reply to Wayne Mery (:wsmwk, NI for questions) from comment #5)
> Andrew, does this still happen for you when using a more current version?

Yes.

Comment 7

[Vladimir D. Seleznev]

It's reproducible to me, Firefox 66.0.1 (64-bit) on Linux.

Comment 8

[Vladimir D. Seleznev]

But in my case the pinned tabs do not restored as well as ordinary tabs.

Comment 9

[Gian-Carlo Pascutto [:gcp]]

I managed to hit this in currently Nightly. Not exactly STR but:

a) After a restart (with correct tabs) the New Tab Page did not respond to clicks.
b) Closed the browser, restart.
c) Browser restarts only with the pinned tabs.
d) History->Recently Closed Windows restores all other tabs, but now in a separate window.

Comment 10

[:Gijs (he/him)]

(In reply to Gian-Carlo Pascutto [:gcp] from comment #9)

I managed to hit this in currently Nightly. Not exactly STR but:

a) After a restart (with correct tabs) the New Tab Page did not respond to clicks.
b) Closed the browser, restart.
c) Browser restarts only with the pinned tabs.
d) History->Recently Closed Windows restores all other tabs, but now in a separate window.

Any errors in the browser console when this happens? Is the state of the session restore pref still correct if checked in the settings?

Comment 11

[Gian-Carlo Pascutto [:gcp]]

The pref is still correct (at least when I check now?).

I'll check the browser console next time it happens.

Comment 12

[Gian-Carlo Pascutto [:gcp]]

I had filed bug 1885010 for the issue that forced the restart. I guess if we have some error in how our "window" (waves hands vaguely) is set up, it could make sense that session restore gets similarly confused. (But don't ask me why pinned tabs are different from normal ones, somehow).

Comment 13

[:Gijs (he/him)]

(In reply to Gian-Carlo Pascutto [:gcp] from comment #12)

I had filed bug 1885010 for the issue that forced the restart. I guess if we have some error in how our "window" (waves hands vaguely) is set up, it could make sense that session restore gets similarly confused. (But don't ask me why pinned tabs are different from normal ones, somehow).

Pinned tabs are restored even if autorestore is off. This has always worked this way.

Comment 14

[Gian-Carlo Pascutto [:gcp]]

I hit this bug like two times per week, still very reproducible in that sense.