FeedWriter.js needs to use createCodebasePrincipal with global context user id

RESOLVED WONTFIX

Status

()

Firefox
Security
RESOLVED WONTFIX
2 years ago
2 years ago

People

(Reporter: huseby, Assigned: baku)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [OA])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

2 years ago
in browser/components/feeds/FeedWriter.js there is a call to getSimpleCodebasePrincipal that needs to be converted to createCodebasePrincipal with a global context user id.  it is in the init function that sets up the principal for the feed.  since we're not isolating on user context id, we need the global context to be used here.

> 1085     this._feedPrincipal = secman.getSimpleCodebasePrincipal(this._feedURI);
(Assignee)

Comment 1

2 years ago
Created attachment 8704571 [details] [diff] [review]
bug_1237066.patch
Assignee: huseby → amarchesini
Attachment #8704571 - Flags: review?(huseby)
(Assignee)

Updated

2 years ago
Depends on: 1237078
(Reporter)

Updated

2 years ago
Attachment #8704571 - Flags: review?(huseby) → review+
(Assignee)

Updated

2 years ago
Depends on: 1229222
No longer depends on: 1237078
(Reporter)

Comment 2

2 years ago
Created attachment 8718224 [details] [diff] [review]
Bug_1237066.patch
Attachment #8704571 - Attachment is obsolete: true
(Reporter)

Comment 3

2 years ago
getSimpleCodebasePrincipal creates an origin attributes with the default user context ID so we don't need to fix this.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
(Reporter)

Updated

2 years ago
Whiteboard: [OA]
You need to log in before you can comment on or make changes to this bug.