Closed Bug 1237081 Opened 8 years ago Closed 8 years ago

remove the getter of userContextId from nsIDocShell

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
We don't want to expose userContextId from the docShell, but just from the originAttributes dictionary.
Attachment #8704344 - Flags: review?(bugs)
Attachment #8704344 - Flags: review?(bugs) → review+
Er, the try run has multiple bustages including a bc7 bustages that I see on m-i after this landed. Backing this out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a79d5a62e5c48091779dcca8de125e9bbc19020c
Backed out changeset 1b5c66916877 (bug 1237081) for mochitest browser-chrome bustage
Attached patch patchSplinter Review
I still need the setter.
Attachment #8704344 - Attachment is obsolete: true
Attachment #8704522 - Flags: review?(bugs)
in Bug 1193854 you added getter and there was already setter
why isn't that old setter enough?
(In reply to Olli Pettay [:smaug] from comment #6)
> in Bug 1193854 you added getter and there was already setter
> why isn't that old setter enough?

The older setter was not exposed in nsIDocShell.
Attachment #8704522 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/5435dcc651f0
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: