Closed
Bug 1237081
Opened 8 years ago
Closed 8 years ago
remove the getter of userContextId from nsIDocShell
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
References
Details
Attachments
(1 file, 1 obsolete file)
4.95 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
We don't want to expose userContextId from the docShell, but just from the originAttributes dictionary.
Attachment #8704344 -
Flags: review?(bugs)
Updated•8 years ago
|
Attachment #8704344 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 1•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5c092197552
Keywords: checkin-needed
Comment 3•8 years ago
|
||
Er, the try run has multiple bustages including a bc7 bustages that I see on m-i after this landed. Backing this out.
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a79d5a62e5c48091779dcca8de125e9bbc19020c Backed out changeset 1b5c66916877 (bug 1237081) for mochitest browser-chrome bustage
Assignee | ||
Comment 5•8 years ago
|
||
I still need the setter.
Attachment #8704344 -
Attachment is obsolete: true
Attachment #8704522 -
Flags: review?(bugs)
Comment 6•8 years ago
|
||
in Bug 1193854 you added getter and there was already setter why isn't that old setter enough?
Assignee | ||
Comment 7•8 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #6) > in Bug 1193854 you added getter and there was already setter > why isn't that old setter enough? The older setter was not exposed in nsIDocShell.
Updated•8 years ago
|
Attachment #8704522 -
Flags: review?(bugs) → review+
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5435dcc651f0
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•