1237124 - Intermittent browser_webconsole_bug_658368_time_methods.js | Uncaught exception - at :0 - Error: operation not possible on dead CPOW

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://treeherder.mozilla.org/logviewer.html#?job_id=6440018&repo=fx-team

Comment 1

[Intermittent Failures Robot]

6 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 6

Platform breakdown:
* linux64: 3
* linux32: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1237124&startday=2016-01-18&endday=2016-01-24&tree=all

Comment 2

[Lin Clark [:linclark]]

This one popped up again with a couple of failures in the past few weeks.

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: MozReview Request: Bug 1237124 - Remove CPOW usage in browser_webconsole_bug_658368_time_methods.js;r=linclark

Review commit: https://reviewboard.mozilla.org/r/41567/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41567/

Comment 4

[Brian Grinstead [:bgrins]]

Saw this come up on a try push, so going to fix it up.  New try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e8b6f673d20

Comment 5

[Lin Clark [:linclark]]

Comment on attachment 8733118 [details]
MozReview Request: Bug 1237124 - Remove CPOW usage in browser_webconsole_bug_658368_time_methods.js;r=linclark

https://reviewboard.mozilla.org/r/41567/#review38201

::: devtools/client/webconsole/test/browser_webconsole_bug_658368_time_methods.js:49
(Diff revision 1)
>                 "bTimer was not started", false, true);
>  
>    // The next test makes sure that timers with the same name but in separate
>    // pages, do not contain the same value.
> -  content.location = TEST_URI3;
> +  ContentTask.spawn(gBrowser.selectedBrowser, TEST_URI3, function*(location) {
> +    content.location = location;

Should we use BrowserTestUtils.loadURI here instead of content.location? I think you might have suggested that for one of my patches before. I'm fine with committing it as is, though.

Comment 6

[Brian Grinstead [:bgrins]]

(In reply to Lin Clark [:linclark] from comment #5)
> Comment on attachment 8733118 [details]
> MozReview Request: Bug 1237124 - Remove CPOW usage in
> browser_webconsole_bug_658368_time_methods.js;r=linclark
> 
> https://reviewboard.mozilla.org/r/41567/#review38201
> 
> :::
> devtools/client/webconsole/test/browser_webconsole_bug_658368_time_methods.
> js:49
> (Diff revision 1)
> >                 "bTimer was not started", false, true);
> >  
> >    // The next test makes sure that timers with the same name but in separate
> >    // pages, do not contain the same value.
> > -  content.location = TEST_URI3;
> > +  ContentTask.spawn(gBrowser.selectedBrowser, TEST_URI3, function*(location) {
> > +    content.location = location;
> 
> Should we use BrowserTestUtils.loadURI here instead of content.location? I
> think you might have suggested that for one of my patches before. I'm fine
> with committing it as is, though.

Right, good idea.  Going to make that change, make sure it passes and then land

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1f504df693e9

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1f504df693e9