Closed Bug 1237124 Opened 8 years ago Closed 8 years ago

Intermittent browser_webconsole_bug_658368_time_methods.js | Uncaught exception - at :0 - Error: operation not possible on dead CPOW

Categories

(DevTools :: Console, defect, P3)

defect

Tracking

(e10s+, firefox48 fixed)

RESOLVED FIXED
Firefox 48
Tracking Status
e10s + ---
firefox48 --- fixed

People

(Reporter: KWierso, Assigned: bgrins)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, Whiteboard: [btpp-backlog])

Attachments

(1 file)

This one popped up again with a couple of failures in the past few weeks.
Priority: -- → P3
Whiteboard: [btpp-backlog]
Saw this come up on a try push, so going to fix it up.  New try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e8b6f673d20
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8733118 - Flags: review?(lclark) → review+
Comment on attachment 8733118 [details]
MozReview Request: Bug 1237124 - Remove CPOW usage in browser_webconsole_bug_658368_time_methods.js;r=linclark

https://reviewboard.mozilla.org/r/41567/#review38201

::: devtools/client/webconsole/test/browser_webconsole_bug_658368_time_methods.js:49
(Diff revision 1)
>                 "bTimer was not started", false, true);
>  
>    // The next test makes sure that timers with the same name but in separate
>    // pages, do not contain the same value.
> -  content.location = TEST_URI3;
> +  ContentTask.spawn(gBrowser.selectedBrowser, TEST_URI3, function*(location) {
> +    content.location = location;

Should we use BrowserTestUtils.loadURI here instead of content.location? I think you might have suggested that for one of my patches before. I'm fine with committing it as is, though.
(In reply to Lin Clark [:linclark] from comment #5)
> Comment on attachment 8733118 [details]
> MozReview Request: Bug 1237124 - Remove CPOW usage in
> browser_webconsole_bug_658368_time_methods.js;r=linclark
> 
> https://reviewboard.mozilla.org/r/41567/#review38201
> 
> :::
> devtools/client/webconsole/test/browser_webconsole_bug_658368_time_methods.
> js:49
> (Diff revision 1)
> >                 "bTimer was not started", false, true);
> >  
> >    // The next test makes sure that timers with the same name but in separate
> >    // pages, do not contain the same value.
> > -  content.location = TEST_URI3;
> > +  ContentTask.spawn(gBrowser.selectedBrowser, TEST_URI3, function*(location) {
> > +    content.location = location;
> 
> Should we use BrowserTestUtils.loadURI here instead of content.location? I
> think you might have suggested that for one of my patches before. I'm fine
> with committing it as is, though.

Right, good idea.  Going to make that change, make sure it passes and then land
https://hg.mozilla.org/mozilla-central/rev/1f504df693e9
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.