1237144 - Improve telemetry probes to understand how people use the recent tabs panel

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[:Margaret Leibovic]

Right now we don't distinguish between URLs loaded from "tabs from last time" and "recently closed tabs". I want to understand how much people are using each of these.

Comment 1

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1237144 - Improve telemetry probes to understand how people use the recent tabs panel. r=mfinkle p=mfinkle

Review commit: https://reviewboard.mozilla.org/r/29667/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29667/

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8704450 [details]
MozReview Request: Bug 1237144 - Improve telemetry probes to understand how people use the recent tabs panel. r=mfinkle p=mfinkle

https://reviewboard.mozilla.org/r/29667/#review26501

::: mobile/android/base/java/org/mozilla/gecko/home/RecentTabsPanel.java:57
(Diff revision 1)
> +    private static final String TELEMETRY_EXTRA_LAST_TIME = "recent-tabs-last-time";

Pedantic I know, but we use underscores as separators in other LOAD_URL extras. Yes, some dashes have slipped into other places. I am not vigilant enough.

We won't be able to use the processing scripts to convert the old data to the new format since we are splitting into two new categories. Such is the way of telemetry.

Comment 3

[:Margaret Leibovic]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 8704450 [details]
> MozReview Request: Bug 1237144 - Improve telemetry probes to understand how
> people use the recent tabs panel. r=mfinkle p=mfinkle
> 
> https://reviewboard.mozilla.org/r/29667/#review26501
> 
> ::: mobile/android/base/java/org/mozilla/gecko/home/RecentTabsPanel.java:57
> (Diff revision 1)
> > +    private static final String TELEMETRY_EXTRA_LAST_TIME = "recent-tabs-last-time";
> 
> Pedantic I know, but we use underscores as separators in other LOAD_URL
> extras. Yes, some dashes have slipped into other places. I am not vigilant
> enough.
> 
> We won't be able to use the processing scripts to convert the old data to
> the new format since we are splitting into two new categories. Such is the
> way of telemetry.

I actually originally had underscores, but I thought those only stemmed from when we automatically included IDs, and that manual extras used dashes... is it worth coming up with a policy here?

I feel like in this case dashes are actually better because it shows that this doesn't correspond to an ID in the app.

Comment 4

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/c3838f540f32f2f6da86bb607f7b394e695c4253
Bug 1237144 - Improve telemetry probes to understand how people use the recent tabs panel. r=mfinkle p=mfinkle

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c3838f540f32