1237152 - rename "clear-origin-data"

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

As smaug pointed out in 
https://bugzilla.mozilla.org/show_bug.cgi?id=1165214#c134
https://bugzilla.mozilla.org/show_bug.cgi?id=1165214#c137

He suggests to rename 'clear-origin-data'

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Yoshi Huang[:allstars.chh] from comment #0)
> As smaug pointed out in 
> https://bugzilla.mozilla.org/show_bug.cgi?id=1165214#c134
> https://bugzilla.mozilla.org/show_bug.cgi?id=1165214#c137
> 
> He suggests to rename 'clear-origin-data'
typo, should be clear-origin-attributes-data

ni? Bobby and Jonas if they also agree the naming.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Sure, I don't have a strong opinion

Comment 3

[Bobby Holley (:bholley)]

Sure.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Right now I am fixing Bug 1195930 and Ethan is fixing Bug 1214071, I'll start this bug once these two are fixed.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eed8b45ca273

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ed77d15346d

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8797978 [details] [diff] [review]
Patch.

https://dxr.mozilla.org/addons/search?q=clear-origin-data&redirect=false seems to return 0 results. Good.

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch. v2

rebase

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6f37cd67e82
rename clear-origin-data to clear-origin-attributes-data, r=smaug

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d6f37cd67e82