Closed Bug 1237152 Opened 4 years ago Closed 3 years ago

rename "clear-origin-data"

Categories

(Core Graveyard :: DOM: Apps, defect)

defect
Not set

Tracking

(firefox46 affected, firefox52 fixed)

RESOLVED FIXED
mozilla52
Tracking Status
firefox46 --- affected
firefox52 --- fixed

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

Details

Attachments

(1 file, 1 obsolete file)

(In reply to Yoshi Huang[:allstars.chh] from comment #0)
> As smaug pointed out in 
> https://bugzilla.mozilla.org/show_bug.cgi?id=1165214#c134
> https://bugzilla.mozilla.org/show_bug.cgi?id=1165214#c137
> 
> He suggests to rename 'clear-origin-data'
typo, should be clear-origin-attributes-data

ni? Bobby and Jonas if they also agree the naming.
Flags: needinfo?(jonas)
Flags: needinfo?(bobbyholley)
Sure, I don't have a strong opinion
Flags: needinfo?(jonas)
Sure.
Flags: needinfo?(bobbyholley)
Assignee: nobody → allstars.chh
Right now I am fixing Bug 1195930 and Ethan is fixing Bug 1214071, I'll start this bug once these two are fixed.
Status: NEW → ASSIGNED
Comment on attachment 8797978 [details] [diff] [review]
Patch.

https://dxr.mozilla.org/addons/search?q=clear-origin-data&redirect=false seems to return 0 results. Good.
Attachment #8797978 - Flags: review?(bugs) → review+
Attached patch Patch. v2Splinter Review
rebase
Attachment #8797978 - Attachment is obsolete: true
Attachment #8798742 - Flags: review+
Pushed by yhuang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6f37cd67e82
rename clear-origin-data to clear-origin-attributes-data, r=smaug
https://hg.mozilla.org/mozilla-central/rev/d6f37cd67e82
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.