Closed
Bug 1237152
Opened 8 years ago
Closed 8 years ago
rename "clear-origin-data"
Categories
(Core Graveyard :: DOM: Apps, defect)
Core Graveyard
DOM: Apps
Tracking
(firefox46 affected, firefox52 fixed)
RESOLVED
FIXED
mozilla52
People
(Reporter: allstars.chh, Assigned: allstars.chh)
References
Details
Attachments
(1 file, 1 obsolete file)
|
29.40 KB,
patch
|
allstars.chh
:
review+
|
Details | Diff | Splinter Review |
As smaug pointed out in https://bugzilla.mozilla.org/show_bug.cgi?id=1165214#c134 https://bugzilla.mozilla.org/show_bug.cgi?id=1165214#c137 He suggests to rename 'clear-origin-data'
|
Assignee | |
Updated•8 years ago
|
Blocks: nsec-origins
|
|
Assignee | |
Comment 1•8 years ago
|
||
(In reply to Yoshi Huang[:allstars.chh] from comment #0) > As smaug pointed out in > https://bugzilla.mozilla.org/show_bug.cgi?id=1165214#c134 > https://bugzilla.mozilla.org/show_bug.cgi?id=1165214#c137 > > He suggests to rename 'clear-origin-data' typo, should be clear-origin-attributes-data ni? Bobby and Jonas if they also agree the naming.
Flags: needinfo?(jonas)
Flags: needinfo?(bobbyholley)
Sure, I don't have a strong opinion
Flags: needinfo?(jonas)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → allstars.chh
|
|
Assignee | |
Comment 4•8 years ago
|
||
Right now I am fixing Bug 1195930 and Ethan is fixing Bug 1214071, I'll start this bug once these two are fixed.
|
|
Assignee | |
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=eed8b45ca273
|
|
Assignee | |
Comment 6•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ed77d15346d
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8797978 -
Flags: review?(bugs)
|
||
Comment 7•8 years ago
|
||
Comment on attachment 8797978 [details] [diff] [review] Patch. https://dxr.mozilla.org/addons/search?q=clear-origin-data&redirect=false seems to return 0 results. Good.
Attachment #8797978 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 8•8 years ago
|
||
rebase
Attachment #8797978 -
Attachment is obsolete: true
Attachment #8798742 -
Flags: review+
Pushed by yhuang@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d6f37cd67e82 rename clear-origin-data to clear-origin-attributes-data, r=smaug
|
||
Comment 10•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d6f37cd67e82
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•