58 bytes, text/x-review-board-request
Linux ppc64 builds are failing with 2:23.98 ============================== 2:23.98 ERROR PROCESSING MOZBUILD FILE 2:23.98 ============================== 2:23.98 2:23.98 The error occurred while processing the following file or one of the files it includes: 2:23.98 2:23.99 /media/nfs/usb_drive_src/firefox/mozilla-central-hg/src/testing/tools/fileid/moz.build 2:23.99 2:23.99 The error occurred when validating the result of the execution. The reported error is: 2:23.99 2:23.99 USE_LIBS contains "breakpad_linux_common_s", which does not match any LIBRARY_NAME in the tree. 2:23.99 2:23.99 I think this is because breakpad doesn't get built on non crash reporter (or maybe non SPS-Profiler) platforms
It's kinda both, although it will go back to only being built on platforms that don't disable-crashreporter once I finish bug 1069556.
Review commit: https://reviewboard.mozilla.org/r/29731/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/29731/
Comment on attachment 8704742 [details] MozReview Request: Bug 1237156 - Only build the fileid utility when MOZ_CRASHREPORTER is set. r=ted Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29731/diff/1-2/
Attachment #8704742 - Flags: review?(ted)
Attachment #8704742 - Flags: review?(ted) → review+
Comment on attachment 8704742 [details] MozReview Request: Bug 1237156 - Only build the fileid utility when MOZ_CRASHREPORTER is set. r=ted https://reviewboard.mozilla.org/r/29731/#review26571 Thanks, I actually just hit this on Try after rebasing my "update breakpad" patch because it no longer builds this stuff when the profiler is enabled, so a bunch of builds broke!
You need to log in before you can comment on or make changes to this bug.