123719 - Default account is not placed at the top of the folder pane

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Katsuhiko Momoi]

** Observed with 2002-02-04 trunk build **

This has been going on for the last few days.
For some reason, the default mail account folder does not get 
placed at the top and shows up below 2 NS webmail account folders.
When this happens, the Inbox folder for that account is also
not at the top and is instead placed at the position where you
will find mail folders with names beginning with "I".

Comment 1

[Ninoschka Baca]

Trunk build 2002-02-13-03: WinMe, I'm having problems duplicating the problem. 

Some questions:
1. How was the profile created (Migrated, New)?
2. How old is this profile/what build was being used when the profile was created.
3. Did you use Activation to create one of the WebMail accounts?
4. Do you recall in what order were the accounts added to the profile?
5. Did you ever change the default account?

Comment 2

[Katsuhiko Momoi]

> 1. How was the profile created (Migrated, New)?
> 2. How old is this profile/what build was being used when the profile was created.


This profile was created new within the last month or so
using 0.9.8 trunk build at some point. Windows 2000.

> 3. Did you use Activation to create one of the WebMail accounts?

Yes. I used activation and added my main account and one additional
account for Netscape later on.

> 4. Do you recall in what order were the accounts added to the profile?

Netscape web mail 1, an IMAP account, Netscape web mail 2, Mozilla.org
news server account, another news server account, another IMAP account.

As I recall, the above was the order in which the accounts were added.

> 5. Did you ever change the default account?

Yes. I believe Netscape Web mail was the default account at the 
beginning. The deafult was changed to an IMAP account almost
at the beginning of this new profile.

Comment 3

[Katsuhiko Momoi]

Maybe we should move this bug to Netscape internal
bug database?

Comment 4

[Katsuhiko Momoi]

> Maybe we should move this bug to Netscape internal
> bug database?

OK, we don't have to do this. I can reproduce this
problem with the current Mozilla trunk build also.

I did a bit of investigation on what steps lead to
this problem. Here's a reproducible set of steps.

1. Have at least 2 IMAP (or probably POP) accounts created.
   Designate one of them as the default account.
   If you have a Netscape build, add an NS Webmail account.
2. Now open the Mail window. Login in and read some messages.
   I assume here that you have:

   1. Mail folder pane open.  and
   2. Both the thread pane and view pane open.

3. Close the mail folder pane by clicking on the grippie.
4. Close the view pane by clicking on the horizontal grippie.
5. Now you have only the thread pane open.
6. Select a message and double-click on it to view a message. 
   Close this window (This may not be a critical step.)
7. Now quit the application.
8. Re-start the application and open the Mail window.
9. This will open the mail window with no dialog shown and
   the mail folder pane closed. Something is already wrong here.
10. Now open the mail folder pane by clicking on the vertical grippie.
11. Observe where the default account folder is and where the
    default folders such as Inbox and Sent are.

    If you're using a Mozilla build, you will see Inbox folder not at 
    the top position but at the position described originally
    in this report.

    If you're using a Netscape build, in addition to the Inbox and
    Sent folder positioning problem as in a Mozilla build, you also 
    notice that Webmail account icon(s) are placed aboved the default mail 
    account icon. 

I would like to get this fixed soon. Nominating for nsbeta1.

Comment 5

[Katsuhiko Momoi]

Additional information:

It turns out steps 4-6 are not needed to reproduce this problem. 
All that is needed is that the Mail folder pane is closed when 
the application is quit. You will then get this problem.

Comment 6

[Katsuhiko Momoi]

Additional info 2:

It seems that when I change 3-pane configuration to
less than that -- like 2 or 1 pane and then quit the 
application. I get a crash the very next time I start
the application. If I then start it again, it starts
up OK. This crash problem is observed in both Mozilla
and Netscape builds.

Comment 7

[Ninoschka Baca]

Trunk build 2002-02-20-03: WinMe

- Using a profile with 1 WebMail, and 2 IMAP accounts. 
Results: With the folder pane closed, the order of the mail accounts is not 
changed.

Workaround: Open the folder pane, close/reopen the mail window, and now it 
displays the "new" default account at the top. 

Additional Information:
- The account icon always appeared next to the account name in the folder pane.
- The Inbox folder always appeared at the top, under the account level, with a 
special icon.
- I did not experience a crash after exiting in any of my scenarios

Question: Are you using Turbo (Quick launch)?

Comment 8

[Katsuhiko Momoi]

Using the same 2002-02-20 Win32 build, I still have the same problem
as reported originally. It does not make a difference whether or
not Quick Launch is ON.

Comment 9

[Ninoschka Baca]

We determined the reason for the difference.

The workaround works initially but as soon as the user closes the folder pane 
and does an exit/restart (or open/close) of Mail then it reverts back to WebMail 
being the top folder. 

Comment 10

[Michael Buckland]

Discussed in 2/27/02 Mail & News bug meeting.  Decisions was to minus and Future
this bug.

Comment 11

[Katsuhiko Momoi]

I disagree. We should not be shipping a product with this kind
of visible problem. Users will be very annoyed. If you have your
folder pane closed, you will have not only the default account placed 
below your NetCenter accounts but also Inbox and Sent folders will be
out of place. I think this will be a big issue for localized builds as well
because I suspect that re-ordering of folders occur under non-Western locale.
Removing - from the nsbeta-.

If you need me to be present at a meeting, please call me in.

Comment 12

[Katsuhiko Momoi]

This should be fixed before the next NS release because:

1. Any user who uses 2 panes (instead of) 3 panes would
   get this problem.
2. If you have a NS Webmail account, even if you designate
   your POP or IMAP account as the default account, you will
   see that default account after the Webmail accounts.
3. Inbox and Sent folders are alphabetically placed -- not
   at the top.

This affects commercial release mostly and so we can move this
to the internal bug database if needed. 

Comment 13

[Katsuhiko Momoi]

Attachment: Image of the initial Mail window when this problem occurs.

This is teh view of the mail folder when you first 
open it if this problem is present. Note the empty 
thread pane and other problems.

Comment 14

[Katsuhiko Momoi]

Attachment: Image of the initial Mail window when this problem occurs.

This is the view of the mail folder when you first 
open it if this problem is present. Note the empty 
thread pane and other problems.

Comment 15

[Katsuhiko Momoi]

Attachment: Image showing the default accoutn below NS Webmail accounts.

Note that you cannot see Inbox or Sent folders in this view
because they are where they will be if sorted alphabetically.

Comment 16

[Katsuhiko Momoi]

Attachment: Image showing default account "ns" below 2 NS Webmail accounts -- better image.

This image shows better what the problem looks like with the 2 Webmail accounts

at top and the 3rd one "momoi@ns" being my real default account.

Comment 17

[Katsuhiko Momoi]

Attachment: Mozilla build: Image of the unsorted mailbox folder problems

This is a view of one of the 2 problems reported here. This
problem is reproducible on Mozilla builds. Note that
the Inbox, Draft, Sent folder are all misplaced.
2002-03-01 Mozilla trunk build.

Comment 18

[[e-mail]]

*** This bug has been marked as a duplicate of 123336 ***

Comment 19

[bobj]

This bug was marked a DUP of bug 123336, but that bug was just marked nsbeta1-.

But I think this bug is more serious, so I'm reopening for reconsideration.

If I create a new profile and activate, Webmail becomes the top account.  When
I start up, it opens the top mail account and not the account that I set
as the default.

The only way I can find to change this is to remove my Webmail account, and
then add it back again.  I don't think this is a workaround that should be
foisted on end-users.

To avoid this problem, I usually cancel out of activation and then manually
add my webmail account later.  I think we want to encourage activation.
This bug discourages it.

Comment 20

[Michael Buckland]

ninoschka, can you reproduce this with bobj's steps?  Do you ever get the
default account at the top?

Comment 21

[Ninoschka Baca]

Summary: The problems I observed were always in the 2pane view with 3 accounts 
present (i.e. 1 Webmail/2 IMAP or 2 IMAP/1WebMail). It seemed ok with 2 
accounts. 


- I was able to reproduce this as stated in Comment# 9 from 2/20/2002.
- I can also reproduce it using the 2002-03-20 build on WinMe

Steps used to reproduce:
1. Create a new profile
2. Activate a WebMail account
3. Add 2 IMAP accounts (i.e. qatest22, qatest33)
4. The order of the accounts while in 3 pane are:
- WebMail
- qatest22
- qatest33
- Local Folders
5. Change the default from WebMail to qatest22
6. Collapse the folder pane so now it is a 2pane view
7. Exit/Restart

Actual Results: 
a. Blank thread pane
b. Open folder pane and the account order is
- WebMail
- qatest22
- Local Folders
- qatest33
c. Open Account Settings and notice the order is correct but does not match the 
folder pane:
- qatest22
- WebMail
- qatest33
- Local Folders

d. If you change to a 3pane view, exit/restart, then the accounts appear in the 
correct order. As soon as you change to a 2pane view, it reverts back to the 
wrong account order in the folder pane. So for the life of this profile the 
account order in the 2pane view will not be correct.

Comment 22

[bobj]

I haven't tried recently, but I thought I saw the problem in 3-pane view.

Comment 23

[[e-mail]]

Attachment: Proposed Patch

Comment 24

[[e-mail]]

Renominating because I have a patch.

Comment 25

[Jan Varga [:janv]]

Attachment: this should be cleaner way, but not tested since mail is horked with current tip

Comment 26

[[e-mail]]

Comment on attachment 81690 [details] [diff] [review]
this should be cleaner way, but not tested since mail is horked with current tip

Not only is the folder pane still not correctly sorted, but the following two
exceptions (plus others hidden by try/catch) still appear in the JS console:
Error: folderTree.treeBoxObject.selection has no properties
Source File: chrome://messenger/content/msgMail3PaneWindow.js
Line: 1051
Error: selection has no properties
Source File: chrome://messenger/content/mail3PaneWindowCommands.js
Line: 872

Comment 27

[Jan Varga [:janv]]

add also |sortDirection="ascending"|

Comment 28

[[e-mail]]

Ok Jan, that resolves one of the JS exceptions that stops MailNews from loading
when the folder pane is collapsed. But the big problem is that MailNews can't
expand the tree to select your inbox until the tree has a view. And the treebody
won't give the tree a view until the tree is visible. So, either you make the
treebody give the tree a view earlier (e.g. when you call the getter) as the
general solution to the problem, or you manually set the view as a special case.

Comment 29

[Jaime Rodriguez, Jr.]

Let's review this one in the RTM timeframe. adt1.0.0- [adt2 RTM]

Comment 30

[scottputterman]

I'd love to see this fixed.  How is this one coming along?

Comment 31

[[e-mail]]

Quick recap of the problem: Mailnews startup needs to be able to select your
default inbox, which requires that it expands your default server, which
requires that the tree view is set. However, the tree only automatically sets
its view when its preferred size is calculated, which never happens for
collapsed trees.

So you can use my patch (attachment 81481 [details] [diff] [review]) which manually sets the view, or
you've got Jan's patch (attachment 81690 [details] [diff] [review]) which only defers the sort of the tree
until you show it, but doesn't allow the rest of mailnews startup to complete,
or you can move the code to set the view from the preferred size to the get view
method.

Comment 32

[(not reading, please use [e-mail] instead)]

I plan on reviewing neils patch soon (tomorrow or friday).

I don't think this will make 1.0, so we should move it out.

Comment 33

[Jan Varga [:janv]]

Neil and I tested a new patch, which fixed this problem.
But it's a quite big change to tree code, it should be tested well.

Next, I think we can get rid of cycleCell() in JS by adding sort attributes to XUL

I'll post this patch soon.

Comment 34

[Jan Varga [:janv]]

Attachment: new patch

Comment 35

[[e-mail]]

Attachment: My version of the patch

This version of nsTreeBodyFrame.css makes it more obvious what hasn't changed.

Comment 36

[Jan Varga [:janv]]

ccing hyatt and bryner

Comment 37

[[e-mail]]

*** Bug 141753 has been marked as a duplicate of this bug. ***

Comment 38

[Jan Varga [:janv]]

Attachment: new patch for mailnews

Neil, could you review this one ?

Comment 39

[[e-mail]]

Comment on attachment 87509 [details] [diff] [review]
new patch for mailnews

Jan assures me that this will not conflict with attachment 83865 [details] [diff] [review] which is still
needed to open the default inbox in two pane mode.

Comment 40

[Brian Ryner (not reading)]

Comment on attachment 83865 [details] [diff] [review]
new patch

r=bryner

Comment 41

[Jan Varga [:janv]]

-> me

Comment 42

[David :Bienvenu]

Comment on attachment 87509 [details] [diff] [review]
new patch for mailnews

sr=bienvenu

Comment 43

[Cavin Song]

The last patch (attachment 87509 [details] [diff] [review]) has been checked into the trunk so should we 
mark it as FIXED? Or are we still waiting for another patch to go in?

Comment 44

[Jan Varga [:janv]]

It would be better to have both patches.
I just can't get an sr= for second patch.
Will be trying until I get one :)

Comment 45

[Blake Ross]

Comment on attachment 83865 [details] [diff] [review]
new patch

sr=blake

Comment 46

[[e-mail]]

*** Bug 144141 has been marked as a duplicate of this bug. ***

Comment 47

[[e-mail]]

Transferring keywords from duplicate bug.

Comment 48

[Jan Varga [:janv]]

fixed

Comment 49

[Ninoschka Baca]

Trunk build 2002-06-21: WinMe, Linux RH 7.1, Mac 10.1.3
Verified/Fixed, after changing the default account, then collapsing the folder 
pane, and an exit/restart, the default account appears at the top as expected.

Comment 50

[Jaime Rodriguez, Jr.]

adt1.0.1 (on ADT's behalf) approval for checkin to the 1.0 branch, pending
drivers' approval. pls check this in asap, the add the "fixed1.0.1" keyword.

Comment 51

[Cavin Song]

*** Bug 144141 has been marked as a duplicate of this bug. ***

Comment 52

[Judson Valeski]

please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.

Comment 53

[Jan Varga [:janv]]

landed on the branch

Comment 54

[Ninoschka Baca]

Branch build 2002-06-27: WinMe, Linux RH 7.1, Mac 10.1.3
verified1.0.1, after changing the default account, then collapsing the folder 
pane, and an exit/restart, the default account appears at the top as expected.